You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by ma...@apache.org on 2008/04/17 18:31:40 UTC
svn propchange: r356562 - svn:log
Author: mamta
Revision: 356562
Modified property: svn:log
Modified: svn:log at Thu Apr 17 09:31:40 2008
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Thu Apr 17 09:31:40 2008
@@ -1,6 +1,6 @@
-DERBY-572: Add support for optimizer hints, provided by the user as SQL comments. Also add upgrade infrastructure for 10.2 release and support new optimizer mechanism to work correctly under soft-upgrade for databases at 10.1 level.
+DERBY-573: Add support for optimizer hints, provided by the user as SQL comments. Also add upgrade infrastructure for 10.2 release and support new optimizer mechanism to work correctly under soft-upgrade for databases at 10.1 level.
-I have the patch for optimizer overrides support in Derby. Alongwith the patch, I have attached the updated functional spec to the JIRA entry Derby-573.
+I have the patch for optimizer overrides support in Derby. Alongwith the patch, I have attached the updated functional spec to the JIRA entry DERBY-573.
Majority of the changes went into the sqlgrammar.jj because Derby engine already has support for them internally. It is the parser that needs to recognize these overrides and pass it on to through the query nodes. The parser now looks for character sequence -- DERBY-PROPERTIES (case insensitive and space between -- and D is optional) and once it finds that, it looks for propertyName=value pairs on that same comment line in parser's propertyList method. The parser does the basic check to make sure that the same property is not used more than once for a given table. The remaining checks on the properties like checking the existence of user specified index etc are done in the bind phase.
Re: svn propchange: r356562 - svn:log
Posted by Mamta Satoor <ms...@gmail.com>.
I had used incorrect jira entry in the commit comments, so fixing it.
thanks,
Mamta
On 4/17/08, mamta@apache.org <ma...@apache.org> wrote:
> Author: mamta
> Revision: 356562
> Modified property: svn:log
>
> Modified: svn:log at Thu Apr 17 09:31:40 2008
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Thu Apr 17 09:31:40 2008
> @@ -1,6 +1,6 @@
> -DERBY-572: Add support for optimizer hints, provided by the user as SQL comments. Also add upgrade infrastructure for 10.2 release and support new optimizer mechanism to work correctly under soft-upgrade for databases at 10.1 level.
> +DERBY-573: Add support for optimizer hints, provided by the user as SQL comments. Also add upgrade infrastructure for 10.2 release and support new optimizer mechanism to work correctly under soft-upgrade for databases at 10.1 level.
>
> -I have the patch for optimizer overrides support in Derby. Alongwith the patch, I have attached the updated functional spec to the JIRA entry Derby-573.
> +I have the patch for optimizer overrides support in Derby. Alongwith the patch, I have attached the updated functional spec to the JIRA entry DERBY-573.
>
> Majority of the changes went into the sqlgrammar.jj because Derby engine already has support for them internally. It is the parser that needs to recognize these overrides and pass it on to through the query nodes. The parser now looks for character sequence -- DERBY-PROPERTIES (case insensitive and space between -- and D is optional) and once it finds that, it looks for propertyName=value pairs on that same comment line in parser's propertyList method. The parser does the basic check to make sure that the same property is not used more than once for a given table. The remaining checks on the properties like checking the existence of user specified index etc are done in the bind phase.
>
>
>