[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20681#discussion_r170787695
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -46,16 +49,19 @@ setHiveContext <- function(sc) {
         })
         hiveSession <- callJMethod(hiveCtx, "sparkSession")
       }
    -  previousSession <- get(".sparkRsession", envir = .sparkREnv)
       assign(".sparkRsession", hiveSession, envir = .sparkREnv)
       assign(".prevSparkRsession", previousSession, envir = .sparkREnv)
    +  assign(".prevSessionConf", previousConf, envir = .sparkREnv)
       hiveSession
     }
     
     unsetHiveContext <- function() {
       previousSession <- get(".prevSparkRsession", envir = .sparkREnv)
    +  previousConf <- get(".prevSessionConf", envir = .sparkREnv)
    +  callJStatic("org.apache.spark.sql.api.r.SQLUtils", "setSparkContextSessionConf", previousSessioni, previousConf)
       assign(".sparkRsession", previousSession, envir = .sparkREnv)
       remove(".prevSparkRsession", envir = .sparkREnv)
    +  remove(".prevSparkConf", envir = .sparkREnv)
    --- End diff --
    
    this should be `. prevSessionConf`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org