You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/02/02 22:03:51 UTC

Review Request 30526: DISPATCH-109: add parsing of subject field

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30526/
-----------------------------------------------------------

Review request for qpid, Alan Conway and Ted Ross.


Bugs: DISPATCH-109
    https://issues.apache.org/jira/browse/DISPATCH-109


Repository: qpid-dispatch


Description
-------

Refactor the field parse logic.  Avoid re-parsing fields previous to the target field.  My understanding of the existing field parsing code may be a littled flawed - please let me know if you see anything that doesn't make sense or seems sub-optimal.


Diffs
-----

  trunk/include/qpid/dispatch/message.h 1656496 
  trunk/src/message.c 1656496 
  trunk/src/message_private.h 1656496 
  trunk/tests/message_test.c 1656496 

Diff: https://reviews.apache.org/r/30526/diff/


Testing
-------

Added a new unit test.


Thanks,

Kenneth Giusti