You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/02/04 17:44:23 UTC

Review Request 74295: RANGER-4069: Add performance tracing instrumentation to Tag Enricher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74295/
-----------------------------------------------------------

Review request for ranger, madhan and Madhan Neethiraj.


Bugs: RANGER-4069
    https://issues.apache.org/jira/browse/RANGER-4069


Repository: ranger


Description
-------

Ranger enriches the access request before it is evaluated for access. One of important steps during enrichment is computing applicable tags and add them to the request's context. Tag enricher is used to figure out the set of applicable tags. 

This Jira adds performance tracing instrumentation to measure time taken by Tag enricher code to find matching tags.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java da06e4161 


Diff: https://reviews.apache.org/r/74295/diff/1/


Testing
-------

Compiled clean and ran all unit tests successfully.


Thanks,

Abhay Kulkarni


Re: Review Request 74295: RANGER-4069: Add performance tracing instrumentation to Tag Enricher

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74295/#review225151
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 4, 2023, 5:44 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74295/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2023, 5:44 p.m.)
> 
> 
> Review request for ranger, madhan and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-4069
>     https://issues.apache.org/jira/browse/RANGER-4069
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger enriches the access request before it is evaluated for access. One of important steps during enrichment is computing applicable tags and add them to the request's context. Tag enricher is used to figure out the set of applicable tags. 
> 
> This Jira adds performance tracing instrumentation to measure time taken by Tag enricher code to find matching tags.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java da06e4161 
> 
> 
> Diff: https://reviews.apache.org/r/74295/diff/1/
> 
> 
> Testing
> -------
> 
> Compiled clean and ran all unit tests successfully.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 74295: RANGER-4069: Add performance tracing instrumentation to Tag Enricher

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74295/#review225152
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Feb. 4, 2023, 5:44 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74295/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2023, 5:44 p.m.)
> 
> 
> Review request for ranger, madhan and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-4069
>     https://issues.apache.org/jira/browse/RANGER-4069
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger enriches the access request before it is evaluated for access. One of important steps during enrichment is computing applicable tags and add them to the request's context. Tag enricher is used to figure out the set of applicable tags. 
> 
> This Jira adds performance tracing instrumentation to measure time taken by Tag enricher code to find matching tags.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java da06e4161 
> 
> 
> Diff: https://reviews.apache.org/r/74295/diff/1/
> 
> 
> Testing
> -------
> 
> Compiled clean and ran all unit tests successfully.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>