You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2014/07/16 05:12:42 UTC
[01/14] git commit: TS-1475: Coverity 1021862 Out-of-bounds access
warning suppressed
Repository: trafficserver
Updated Branches:
refs/heads/master 3cecd886d -> fb9966635
TS-1475: Coverity 1021862 Out-of-bounds access
warning suppressed
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/fb996663
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/fb996663
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/fb996663
Branch: refs/heads/master
Commit: fb9966635c5077f69a86849049a9462f7ae03cc9
Parents: bbd8020
Author: Justin Laue <ju...@fp-x.com>
Authored: Tue Jul 15 16:57:33 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
iocore/cache/Cache.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fb996663/iocore/cache/Cache.cc
----------------------------------------------------------------------
diff --git a/iocore/cache/Cache.cc b/iocore/cache/Cache.cc
index 8d030cf..4d37b30 100644
--- a/iocore/cache/Cache.cc
+++ b/iocore/cache/Cache.cc
@@ -288,8 +288,8 @@ update_cache_config(const char * /* name ATS_UNUSED */, RecDataT /* data_type AT
CacheVC::CacheVC():alternate_index(CACHE_ALT_INDEX_DEFAULT)
{
size_to_init = sizeof(CacheVC) - (size_t) & ((CacheVC *) 0)->vio;
- void* ptr = (void *) &vio; // attempt to silence coverity
- memset(ptr, 0, size_to_init);
+ // coverity[overrun-buffer-arg]
+ memset((void *) &vio, 0, size_to_init);
// the constructor does a memset() on the members that need to be initialized
//coverity[uninit_member]
}
[08/14] git commit: TS-1475: Coverity 1021657 - fix use after free.
Posted by so...@apache.org.
TS-1475: Coverity 1021657 - fix use after free.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/b143adc1
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/b143adc1
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/b143adc1
Branch: refs/heads/master
Commit: b143adc193d6c198d29b603f4b0a50030674959e
Parents: 8cf2e5a
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:24:12 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
iocore/cluster/ClusterAPI.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/b143adc1/iocore/cluster/ClusterAPI.cc
----------------------------------------------------------------------
diff --git a/iocore/cluster/ClusterAPI.cc b/iocore/cluster/ClusterAPI.cc
index 9a9ddaa..d2e07ab 100644
--- a/iocore/cluster/ClusterAPI.cc
+++ b/iocore/cluster/ClusterAPI.cc
@@ -564,9 +564,9 @@ TSSendClusterRPC(TSNodeHandle_t * nh, TSClusterRPCMsg_t * msg)
int len = c->len - sizeof(OutgoingControl *);
ink_release_assert((size_t) len >= sizeof(TSClusterRPCMsg_t));
+ Debug("cluster_api", "TSSendClusterRPC: msg %p dlen %d [%u.%u.%u.%u] sent", msg, len, DOT_SEPARATED(ipaddr.s_addr));
clusterProcessor.invoke_remote(m->pop_ClusterHandler(), rpch->u.internal.cluster_function,
msg, len, (CLUSTER_OPT_STEAL | CLUSTER_OPT_DATA_IS_OCONTROL));
- Debug("cluster_api", "TSSendClusterRPC: msg %p dlen %d [%u.%u.%u.%u] sent", msg, len, DOT_SEPARATED(ipaddr.s_addr));
} else {
Debug("cluster_api", "TSSendClusterRPC: msg %p to [%u.%u.%u.%u] dropped", msg, DOT_SEPARATED(ipaddr.s_addr));
c->freeall();
[11/14] git commit: TS-1475: Coverity 1021817 - fix resource leak.
Posted by so...@apache.org.
TS-1475: Coverity 1021817 - fix resource leak.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/13aa1c86
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/13aa1c86
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/13aa1c86
Branch: refs/heads/master
Commit: 13aa1c862ec9ce33e81a35c30473d7abc10bf67e
Parents: bf2326c
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:40:21 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
mgmt/api/GenericParser.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/13aa1c86/mgmt/api/GenericParser.cc
----------------------------------------------------------------------
diff --git a/mgmt/api/GenericParser.cc b/mgmt/api/GenericParser.cc
index 49ec6fc..341b58c 100644
--- a/mgmt/api/GenericParser.cc
+++ b/mgmt/api/GenericParser.cc
@@ -405,7 +405,7 @@ Rule::icpParse(char *rule, unsigned short minNumToken, unsigned short maxNumToke
tok_iter_state ruleTok_state;
const char *tokenStr = ruleTok.iterFirst(&ruleTok_state);
Token *token;
- TokenList *m_tokenList = new TokenList();
+ TokenList *m_tokenList;
// Sanity Check -- number of token
if (numRuleTok < minNumToken) {
@@ -419,6 +419,7 @@ Rule::icpParse(char *rule, unsigned short minNumToken, unsigned short maxNumToke
}
+ m_tokenList = new TokenList();
for (; tokenStr; tokenStr = ruleTok.iterNext(&ruleTok_state)) {
token = new Token();
token->setName(tokenStr);
[12/14] git commit: TS-1475: Coverity 1021820 - fix resource leak.
Posted by so...@apache.org.
TS-1475: Coverity 1021820 - fix resource leak.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/141b122f
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/141b122f
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/141b122f
Branch: refs/heads/master
Commit: 141b122fed80c2731cd4f0e1311cdbc571331094
Parents: dd2847f
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 15:02:03 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
mgmt/MultiFile.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/141b122f/mgmt/MultiFile.cc
----------------------------------------------------------------------
diff --git a/mgmt/MultiFile.cc b/mgmt/MultiFile.cc
index 07d6060..3e0cdab 100644
--- a/mgmt/MultiFile.cc
+++ b/mgmt/MultiFile.cc
@@ -100,7 +100,7 @@ MultiFile::WalkFiles(ExpandingArray * fileList)
DIR *dir;
char *fileName;
char *filePath;
- char *records_config_filePath = NULL;
+ char *records_config_filePath;
struct stat fileInfo;
struct stat records_config_fileInfo;
fileEntry *fileListEntry;
@@ -138,13 +138,13 @@ MultiFile::WalkFiles(ExpandingArray * fileList)
}
}
delete[]filePath;
+ delete[]records_config_filePath;
}
ats_free(dirEntry);
closedir(dir);
fileList->sortWithFunction(fileEntryCmpFunc);
- delete[]records_config_filePath;
return MF_OK;
}
[10/14] git commit: TS-1475: Coverity 1021819 - fix resource leak.
Posted by so...@apache.org.
TS-1475: Coverity 1021819 - fix resource leak.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/dd2847f2
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/dd2847f2
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/dd2847f2
Branch: refs/heads/master
Commit: dd2847f298deb82e1d9fe851e090282a04ce9c8a
Parents: 42534bd
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:51:58 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
mgmt/api/GenericParser.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/dd2847f2/mgmt/api/GenericParser.cc
----------------------------------------------------------------------
diff --git a/mgmt/api/GenericParser.cc b/mgmt/api/GenericParser.cc
index 27c4290..13e14ca 100644
--- a/mgmt/api/GenericParser.cc
+++ b/mgmt/api/GenericParser.cc
@@ -320,6 +320,7 @@ Rule::cacheParse(char *rule, unsigned short minNumToken, unsigned short maxNumTo
// Every token must have a '=' sign
if (numSubRuleTok < 2) {
setErrorHint("'=' is expected in space-delimited token");
+ delete m_tokenList;
return NULL;
}
[05/14] git commit: TS-1475: Coverity 1021828 Resource leak
Posted by so...@apache.org.
TS-1475: Coverity 1021828 Resource leak
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d44fb575
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d44fb575
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d44fb575
Branch: refs/heads/master
Commit: d44fb57501fa956a44d3338a745227f1e7b3fc12
Parents: 8d2e272
Author: Justin Laue <ju...@fp-x.com>
Authored: Tue Jul 15 14:07:06 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
lib/records/RecFile.cc | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d44fb575/lib/records/RecFile.cc
----------------------------------------------------------------------
diff --git a/lib/records/RecFile.cc b/lib/records/RecFile.cc
index 1bb9750..72190fb 100644
--- a/lib/records/RecFile.cc
+++ b/lib/records/RecFile.cc
@@ -239,11 +239,13 @@ RecPipeConnect(const char *base_path, const char *name)
// set so that child process doesn't inherit our fd
if (fcntl(sockfd, F_SETFD, 1) < 0) {
RecLog(DL_Warning, "[RecPipeConnect] fcntl error\n");
+ close(sockfd);
return REC_HANDLE_INVALID;
}
// blocking connect
if ((connect(sockfd, (struct sockaddr *) &servaddr, servaddr_len)) < 0) {
RecLog(DL_Warning, "[RecPipeConnect] connect error\n");
+ close(sockfd);
return REC_HANDLE_INVALID;
}
[09/14] git commit: TS-1475: Coverity 1021790 - fix resource leak.
Posted by so...@apache.org.
TS-1475: Coverity 1021790 - fix resource leak.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/bf2326cd
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/bf2326cd
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/bf2326cd
Branch: refs/heads/master
Commit: bf2326cd128f180df2205f12c5987eda94396f59
Parents: b143adc
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:33:51 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
plugins/gzip/misc.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/bf2326cd/plugins/gzip/misc.cc
----------------------------------------------------------------------
diff --git a/plugins/gzip/misc.cc b/plugins/gzip/misc.cc
index aeb6f30..7671656 100644
--- a/plugins/gzip/misc.cc
+++ b/plugins/gzip/misc.cc
@@ -180,6 +180,7 @@ load_dictionary(const char *preload_file)
}
}
dict[i - 1] = '\0';
+ fclose(fp);
/* TODO get the adler compute right */
*adler = adler32(*adler, (const Byte *) dict, sizeof(dict));
[04/14] git commit: TS-1475: Coverity 1021655 - fix use after free.
Posted by so...@apache.org.
TS-1475: Coverity 1021655 - fix use after free.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/8d2e2729
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/8d2e2729
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/8d2e2729
Branch: refs/heads/master
Commit: 8d2e272961a8f8ab23f132915071635c1b1e7a71
Parents: 3cecd88
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:00:48 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
lib/ts/HostLookup.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8d2e2729/lib/ts/HostLookup.cc
----------------------------------------------------------------------
diff --git a/lib/ts/HostLookup.cc b/lib/ts/HostLookup.cc
index bdb4a05..863d124 100644
--- a/lib/ts/HostLookup.cc
+++ b/lib/ts/HostLookup.cc
@@ -945,8 +945,7 @@ HostLookup::InsertBranch(HostBranch * insert_in, const char *level_data)
switch (insert_in->type) {
case HOST_TERMINAL:
// Should not happen
- ink_assert(0);
- delete new_branch;
+ ink_release_assert(0);
break;
case HOST_HASH:
ink_hash_table_insert((InkHashTable *) insert_in->next_level, (char *) level_data, new_branch);
[14/14] git commit: TS-1475: Coverity 1196454 - fix resource leak
Posted by so...@apache.org.
TS-1475: Coverity 1196454 - fix resource leak
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a890d312
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a890d312
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a890d312
Branch: refs/heads/master
Commit: a890d31215a4ce00b51f9d9845207de27e8ab957
Parents: 141b122
Author: JvD <ja...@cable.comcast.com>
Authored: Tue Jul 15 15:03:28 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
plugins/experimental/buffer_upload/buffer_upload.cc | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a890d312/plugins/experimental/buffer_upload/buffer_upload.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/buffer_upload/buffer_upload.cc b/plugins/experimental/buffer_upload/buffer_upload.cc
index 11d1f56..df0f3d8 100644
--- a/plugins/experimental/buffer_upload/buffer_upload.cc
+++ b/plugins/experimental/buffer_upload/buffer_upload.cc
@@ -951,11 +951,14 @@ create_directory()
}
}
dir = opendir(".");
+ if (dir == NULL)
+ goto error_out;
while ((d = readdir(dir))) {
remove(d->d_name);
}
if (chdir("..") == -1) return 0;
}
+ closedir(dir);
if (chdir(cwd) == -1) return 0;
return 1;
[06/14] git commit: TS-1475: Coverity 1021656 - fix use after free.
Posted by so...@apache.org.
TS-1475: Coverity 1021656 - fix use after free.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/efc8f0af
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/efc8f0af
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/efc8f0af
Branch: refs/heads/master
Commit: efc8f0af9dc3b09dbd1588fa8715870f5e22dc0c
Parents: d44fb57
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:18:00 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
iocore/cluster/ClusterProcessor.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/efc8f0af/iocore/cluster/ClusterProcessor.cc
----------------------------------------------------------------------
diff --git a/iocore/cluster/ClusterProcessor.cc b/iocore/cluster/ClusterProcessor.cc
index eb73de1..a37d0a3 100644
--- a/iocore/cluster/ClusterProcessor.cc
+++ b/iocore/cluster/ClusterProcessor.cc
@@ -69,9 +69,6 @@ ClusterProcessor::internal_invoke_remote(ClusterHandler *ch, int cluster_fn,
if (!ch || (!malloced && !((unsigned int) cluster_fn < (uint32_t) SIZE_clusterFunction))) {
// Invalid message or node is down, free message data
- if (malloced) {
- ats_free(data);
- }
if (cmsg) {
invoke_remote_data_args *args = (invoke_remote_data_args *)
(((OutgoingControl *) cmsg)->data + sizeof(int32_t));
@@ -84,6 +81,9 @@ ClusterProcessor::internal_invoke_remote(ClusterHandler *ch, int cluster_fn,
c = *((OutgoingControl **) ((char *) data - sizeof(OutgoingControl *)));
c->freeall();
}
+ if (malloced) {
+ ats_free(data);
+ }
return -1;
}
[02/14] git commit: TS-1475: Coverity 1021791,
1021792 - fix resource leaks
Posted by so...@apache.org.
TS-1475: Coverity 1021791,1021792 - fix resource leaks
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/4dbd98ef
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/4dbd98ef
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/4dbd98ef
Branch: refs/heads/master
Commit: 4dbd98ef2092b4642aef379819333265ba21ca0c
Parents: a890d31
Author: JvD <ja...@cable.comcast.com>
Authored: Tue Jul 15 15:05:41 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
plugins/experimental/esi/esi.cc | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/4dbd98ef/plugins/experimental/esi/esi.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/esi/esi.cc b/plugins/experimental/esi/esi.cc
index d8665cb..c6858b4 100644
--- a/plugins/experimental/esi/esi.cc
+++ b/plugins/experimental/esi/esi.cc
@@ -1702,12 +1702,14 @@ TSPluginInit(int argc, const char *argv[]) {
return;
}
if (esiPluginInit(argc, argv, pOptionInfo) != 0) {
+ TSfree(pOptionInfo);
return;
}
TSCont global_contp = TSContCreate(globalHookHandler, NULL);
if (!global_contp) {
TSError("[%s] Could not create global continuation", __FUNCTION__);
+ TSfree(pOptionInfo);
return;
}
TSContDataSet(global_contp, pOptionInfo);
@@ -1766,6 +1768,7 @@ TSRemapNewInstance(int argc, char* argv[], void** ih, char* errbuf, int errbuf_s
}
if (esiPluginInit(index, new_argv, pOptionInfo) != 0) {
snprintf(errbuf, errbuf_size, "esiPluginInit fail!");
+ TSfree(pOptionInfo);
return TS_ERROR;
}
TSCont contp = TSContCreate(globalHookHandler, NULL);
[07/14] git commit: TS-1475: Coverity 1226155 Resource leak
Posted by so...@apache.org.
TS-1475: Coverity 1226155 Resource leak
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/8cf2e5a9
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/8cf2e5a9
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/8cf2e5a9
Branch: refs/heads/master
Commit: 8cf2e5a9779752aecc2ba179c86588aa91142655
Parents: efc8f0a
Author: Justin Laue <ju...@fp-x.com>
Authored: Tue Jul 15 14:20:28 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
lib/records/RecFile.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8cf2e5a9/lib/records/RecFile.cc
----------------------------------------------------------------------
diff --git a/lib/records/RecFile.cc b/lib/records/RecFile.cc
index 72190fb..0b16198 100644
--- a/lib/records/RecFile.cc
+++ b/lib/records/RecFile.cc
@@ -34,7 +34,7 @@ RecHandle
RecFileOpenR(const char *file)
{
RecHandle h_file;
- return ((h_file =::open(file, O_RDONLY)) <= 0) ? REC_HANDLE_INVALID : h_file;
+ return ((h_file =::open(file, O_RDONLY)) < 0) ? REC_HANDLE_INVALID : h_file;
}
//-------------------------------------------------------------------------
[03/14] git commit: TS-1475: Coverity 1021818 - fix resource leak.
Posted by so...@apache.org.
TS-1475: Coverity 1021818 - fix resource leak.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/42534bdd
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/42534bdd
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/42534bdd
Branch: refs/heads/master
Commit: 42534bdd08210571f1a0aa29035ddd750da2acf2
Parents: 13aa1c8
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Tue Jul 15 14:51:27 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
mgmt/api/GenericParser.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/42534bdd/mgmt/api/GenericParser.cc
----------------------------------------------------------------------
diff --git a/mgmt/api/GenericParser.cc b/mgmt/api/GenericParser.cc
index 341b58c..27c4290 100644
--- a/mgmt/api/GenericParser.cc
+++ b/mgmt/api/GenericParser.cc
@@ -727,6 +727,7 @@ Rule::splitdnsParse(char *rule)
// Every token must have a '=' sign
if (numSubRuleTok < 2) {
setErrorHint("'=' is expected in space-delimited token");
+ delete m_tokenList;
return NULL;
}
[13/14] git commit: TS-1475: Coverity 1021829 Resource leak
Posted by so...@apache.org.
TS-1475: Coverity 1021829 Resource leak
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/bbd80204
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/bbd80204
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/bbd80204
Branch: refs/heads/master
Commit: bbd80204b6dc3977a9eaafbb7663141c972926f1
Parents: 4dbd98e
Author: Justin Laue <ju...@fp-x.com>
Authored: Tue Jul 15 15:17:59 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600
----------------------------------------------------------------------
lib/records/RecFile.cc | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/bbd80204/lib/records/RecFile.cc
----------------------------------------------------------------------
diff --git a/lib/records/RecFile.cc b/lib/records/RecFile.cc
index 0b16198..42f557f 100644
--- a/lib/records/RecFile.cc
+++ b/lib/records/RecFile.cc
@@ -186,17 +186,20 @@ RecPipeCreate(const char *base_path, const char *name)
servaddr_len = sizeof(servaddr.sun_family) + strlen(servaddr.sun_path);
if ((bind(listenfd, (struct sockaddr *) &servaddr, servaddr_len)) < 0) {
RecLog(DL_Warning, "[RecPipeCreate] bind error\n");
+ close(listenfd);
return REC_HANDLE_INVALID;
}
// listen, backlog of 1 (expecting only one client)
if ((listen(listenfd, 1)) < 0) {
RecLog(DL_Warning, "[RecPipeCreate] listen error\n");
+ close(listenfd);
return REC_HANDLE_INVALID;
}
// block until we get a connection from the other side
cliaddr_len = sizeof(cliaddr);
if ((acceptfd = accept(listenfd, (struct sockaddr *) &cliaddr,
&cliaddr_len)) < 0) {
+ close(listenfd);
return REC_HANDLE_INVALID;
}