You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/11 01:42:13 UTC
[kudu-CR] [util] updated output from TryRunLsof()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6852
Change subject: [util] updated output from TryRunLsof()
......................................................................
[util] updated output from TryRunLsof()
TryRunLsof() should not conclude it's called because of an error
binding to the specified address: in some use-cases it might not be the
case. The output is updated to remove the statement about a failure to
bind to the specified address, leaving just the output from lsof.
This is a pure cosmetic fix to improve error message readability
in the context of KUDU-2005.
Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/6852/1
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] updated output from TryRunLsof()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [util] updated output from TryRunLsof()
......................................................................
[util] updated output from TryRunLsof()
TryRunLsof() should not conclude it's called because of an error
binding to the specified address: in some use-cases it might not be the
case. The output is updated to remove the statement about a failure to
bind to the specified address, leaving just the output from lsof.
This is a pure cosmetic fix to improve error message readability
in the context of KUDU-2005.
Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/6852/2
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [util] updated output from TryRunLsof()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] updated output from TryRunLsof()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [util] updated output from TryRunLsof()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] updated output from TryRunLsof()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6852/1/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
PS1, Line 293: if
> Nit: it was more grammatically correct without 'if'.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [util] updated output from TryRunLsof()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] updated output from TryRunLsof()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6852/1/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
PS1, Line 293: if
Nit: it was more grammatically correct without 'if'.
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [util] updated output from TryRunLsof()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [util] updated output from TryRunLsof()
......................................................................
[util] updated output from TryRunLsof()
TryRunLsof() should not conclude it's called because of an error
binding to the specified address: in some use-cases it might not be the
case. The output is updated to remove the statement about a failure to
bind to the specified address, leaving just the output from lsof.
This is a pure cosmetic fix to improve error message readability
in the context of KUDU-2005.
Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Reviewed-on: http://gerrit.cloudera.org:8080/6852
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>