You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2025/07/10 17:00:53 UTC
[PR] [WIP][SQL] Support TIME subtract [spark]
MaxGekk opened a new pull request, #51441:
URL: https://github.com/apache/spark/pull/51441
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2199249067
##########
sql/core/src/test/resources/sql-tests/analyzer-results/time.sql.out:
##########
@@ -521,3 +521,92 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"fragment" : "'10:00:01' :: TIME(1) - INTERVAL '1' MONTH"
} ]
}
+
+
+-- !query
+SELECT TIME'12:30:41' - TIME'10:00'
+-- !query analysis
+Project [12:30:41 - 10:00:00 AS TIME '12:30:41' - TIME '10:00:00'#x]
++- OneRowRelation
+
+
+-- !query
+SELECT TIME'08:30' - NULL
Review Comment:
I think it's consistent with `TIMESTAMP'xxx' - NULL`, but we can always match the NullType explicitly to support this case. Maybe we can discuss it in a followup PR?
##########
sql/core/src/test/resources/sql-tests/inputs/time.sql:
##########
@@ -82,3 +82,11 @@ SELECT '23:59:59.999999' :: TIME - INTERVAL '23:59:59.999999' HOUR TO SECOND;
SELECT '00:00:00.0001' :: TIME(4) - INTERVAL '0 00:00:00.0001' DAY TO SECOND;
SELECT '08:30' :: TIME(0) - INTERVAL '6' HOUR;
SELECT '10:00:01' :: TIME(1) - INTERVAL '1' MONTH;
+
+-- Subtract times
+SELECT TIME'12:30:41' - TIME'10:00';
+SELECT TIME'08:30' - NULL;
+SELECT NULL - TIME'10:32';
+SELECT TIME'12:30:41.123' - TIMESTAMP'10:00:01';
+SELECT '12:30:41.123' - TIME'10:00:01';
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #51441:
URL: https://github.com/apache/spark/pull/51441#issuecomment-3059042586
@dongjoon-hyun @cloud-fan @srielau @yaooqinn Could you review the PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2198880337
##########
sql/core/src/test/resources/sql-tests/analyzer-results/time.sql.out:
##########
@@ -521,3 +521,92 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"fragment" : "'10:00:01' :: TIME(1) - INTERVAL '1' MONTH"
} ]
}
+
+
+-- !query
+SELECT TIME'12:30:41' - TIME'10:00'
+-- !query analysis
+Project [12:30:41 - 10:00:00 AS TIME '12:30:41' - TIME '10:00:00'#x]
++- OneRowRelation
+
+
+-- !query
+SELECT TIME'08:30' - NULL
Review Comment:
Why is this not NULL?
Vast majority of builtin's are "return NULL on NULL input". I'm sure this is true for arithmetic operators in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2203361602
##########
sql/core/src/test/resources/sql-tests/analyzer-results/time.sql.out:
##########
@@ -521,3 +521,92 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"fragment" : "'10:00:01' :: TIME(1) - INTERVAL '1' MONTH"
} ]
}
+
+
+-- !query
+SELECT TIME'12:30:41' - TIME'10:00'
+-- !query analysis
+Project [12:30:41 - 10:00:00 AS TIME '12:30:41' - TIME '10:00:00'#x]
++- OneRowRelation
+
+
+-- !query
+SELECT TIME'08:30' - NULL
Review Comment:
Here is the PR: https://github.com/apache/spark/pull/51454 which changes the behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #51441:
URL: https://github.com/apache/spark/pull/51441#issuecomment-3059048482
cc @peter-toth , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #51441:
URL: https://github.com/apache/spark/pull/51441#issuecomment-3061981723
Merging to master. Thank you, @dongjoon-hyun @cloud-fan @srielau @yaooqinn for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #51441: [SPARK-52763][SQL] Support TIME subtract
URL: https://github.com/apache/spark/pull/51441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2198886507
##########
sql/core/src/test/resources/sql-tests/inputs/time.sql:
##########
@@ -82,3 +82,11 @@ SELECT '23:59:59.999999' :: TIME - INTERVAL '23:59:59.999999' HOUR TO SECOND;
SELECT '00:00:00.0001' :: TIME(4) - INTERVAL '0 00:00:00.0001' DAY TO SECOND;
SELECT '08:30' :: TIME(0) - INTERVAL '6' HOUR;
SELECT '10:00:01' :: TIME(1) - INTERVAL '1' MONTH;
+
+-- Subtract times
+SELECT TIME'12:30:41' - TIME'10:00';
+SELECT TIME'08:30' - NULL;
+SELECT NULL - TIME'10:32';
+SELECT TIME'12:30:41.123' - TIMESTAMP'10:00:01';
+SELECT '12:30:41.123' - TIME'10:00:01';
Review Comment:
An example where start > end perhaps? Showing negative results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2199776691
##########
sql/core/src/test/resources/sql-tests/inputs/time.sql:
##########
@@ -82,3 +82,11 @@ SELECT '23:59:59.999999' :: TIME - INTERVAL '23:59:59.999999' HOUR TO SECOND;
SELECT '00:00:00.0001' :: TIME(4) - INTERVAL '0 00:00:00.0001' DAY TO SECOND;
SELECT '08:30' :: TIME(0) - INTERVAL '6' HOUR;
SELECT '10:00:01' :: TIME(1) - INTERVAL '1' MONTH;
+
+-- Subtract times
+SELECT TIME'12:30:41' - TIME'10:00';
+SELECT TIME'08:30' - NULL;
+SELECT NULL - TIME'10:32';
+SELECT TIME'12:30:41.123' - TIMESTAMP'10:00:01';
+SELECT '12:30:41.123' - TIME'10:00:01';
Review Comment:
added such check, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2199309470
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -606,3 +606,27 @@ case class TimeAddInterval(time: Expression, interval: Expression)
newTime: Expression, newInterval: Expression): TimeAddInterval =
copy(time = newTime, interval = newInterval)
}
+
+/**
+ * Returns a day-time interval between time values.
+ */
+case class SubtractTimes(left: Expression, right: Expression)
+ extends BinaryExpression with RuntimeReplaceable with ExpectsInputTypes {
+ override def nullIntolerant: Boolean = true
+ override def inputTypes: Seq[AbstractDataType] = Seq(AnyTimeType, AnyTimeType)
+
+ override def replacement: Expression = StaticInvoke(
+ classOf[DateTimeUtils.type],
+ DayTimeIntervalType(HOUR, SECOND),
+ "subtractTimes",
+ children,
+ inputTypes
+ )
Review Comment:
```suggestion
inputTypes,
propagateNull = nullIntolerant)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52763][SQL] Support TIME subtract [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51441:
URL: https://github.com/apache/spark/pull/51441#discussion_r2199249813
##########
sql/core/src/test/resources/sql-tests/inputs/time.sql:
##########
@@ -82,3 +82,11 @@ SELECT '23:59:59.999999' :: TIME - INTERVAL '23:59:59.999999' HOUR TO SECOND;
SELECT '00:00:00.0001' :: TIME(4) - INTERVAL '0 00:00:00.0001' DAY TO SECOND;
SELECT '08:30' :: TIME(0) - INTERVAL '6' HOUR;
SELECT '10:00:01' :: TIME(1) - INTERVAL '1' MONTH;
+
+-- Subtract times
+SELECT TIME'12:30:41' - TIME'10:00';
+SELECT TIME'08:30' - NULL;
+SELECT NULL - TIME'10:32';
+SELECT TIME'12:30:41.123' - TIMESTAMP'10:00:01';
+SELECT '12:30:41.123' - TIME'10:00:01';
Review Comment:
oh do we support it? the hour range is 0-23 for TIME type, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org