You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeremy Hanna (JIRA)" <ji...@apache.org> on 2011/07/23 00:06:09 UTC
[jira] [Created] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Make rpc_timeout_in_ms into a jmx mbean property
------------------------------------------------
Key: CASSANDRA-2940
URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
Project: Cassandra
Issue Type: Improvement
Reporter: Jeremy Hanna
When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Ruben Terrazas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176738#comment-13176738 ]
Ruben Terrazas commented on CASSANDRA-2940:
-------------------------------------------
No problem.
If I understand correctly, the preferred approach would be something like this:
-New methods in StorageProxyMBean expose this property.
-StorageProxy implements this as a call to the new static method DatabaseDescriptor.setRpcTimeout(Long).
-DatabaseDescriptor.setRpcTimeout(Long) changes the value of Config.rpc_timeout_in_ms (notice that my understanding is that we should keep this as it is, so that the default value can still be loaded from the yaml file if needed).
If my understanding is correct, I'll be happy to make the change, if not, could you please clarify where you think needed?. Thanks.
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Ruben Terrazas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176909#comment-13176909 ]
Ruben Terrazas commented on CASSANDRA-2940:
-------------------------------------------
Thanks, I just updated the patch. Let me know what you think.
On Wed, Dec 28, 2011 at 12:24 PM, Brandon Williams (Commented) (JIRA) <
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt, trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Jeremy Hanna (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176722#comment-13176722 ]
Jeremy Hanna commented on CASSANDRA-2940:
-----------------------------------------
Thanks for the patch! Talked to Brandon Williams and Nick Bailey about the patch. They don't want to have a Config MBean. Brandon said it would be better to move the property to to StorageProxy but add the setter to DatabaseDescriptor. StorageProxy can call that setter.
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176776#comment-13176776 ]
Brandon Williams commented on CASSANDRA-2940:
---------------------------------------------
{quote}
If I understand correctly, the preferred approach would be something like this:
-New methods in StorageProxyMBean expose this property.
-StorageProxy implements this as a call to the new static method DatabaseDescriptor.setRpcTimeout(Long).
-DatabaseDescriptor.setRpcTimeout(Long) changes the value of Config.rpc_timeout_in_ms (notice that my understanding is that we should keep this as it is, so that the default value can still be loaded from the yaml file if needed).
{quote}
Yes, this is correct, we should never be rewriting the yaml. Thanks!
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Ruben Terrazas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruben Terrazas updated CASSANDRA-2940:
--------------------------------------
Attachment: trunk-CASSANDRA-2940.txt
Updated patch:
Exposed the property in the StorageProxyMBean, and the implementation uses the value of DatabaseDescriptor.conf.rpc_timeout_in_ms. Added setter in DatabaseDescriptor to be able to update the value from StorageProxy.
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt, trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Jonathan Ellis (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-2940:
-----------------------------------------
Assignee: Ruben Terrazas
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Ruben Terrazas
> Labels: jmx, lhf
> Fix For: 1.0.7
>
> Attachments: trunk-CASSANDRA-2940.txt, trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Ruben Terrazas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruben Terrazas updated CASSANDRA-2940:
--------------------------------------
Attachment: trunk-CASSANDRA-2940.txt
Patch I propose for this issue:
I implemented the new ConfigMBean.java interface in the Config.java class, and only exposed the desired property's getter and setter.
I also registered the bean in the Config constructor because it seemed to me the best place to do so, I could have done this in DatabaseDescriptor, but it seemed cleaner to do so here.
I added Jeremy Hanna as reviewer, don't know if this is the right thing to do, but if he could give the patch a look, I'd be appreciative.
As stated in the guidelines, I re-threw exceptions as Runtime exception, since no callers could handle them (ended up in a static block).
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2940:
----------------------------------------
Reviewer: brandon.williams (was: jeromatron)
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2940:
----------------------------------------
Component/s: Core
Fix Version/s: 1.0.7
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeremy Hanna
> Labels: lhf
> Fix For: 1.0.7
>
> Attachments: trunk-CASSANDRA-2940.txt, trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2940:
--------------------------------------
Labels: jmx lhf (was: lhf)
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeremy Hanna
> Labels: jmx, lhf
> Fix For: 1.0.7
>
> Attachments: trunk-CASSANDRA-2940.txt, trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2940) Make rpc_timeout_in_ms into a jmx
mbean property
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-2940:
------------------------------------
Labels: lhf (was: )
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2940) Make rpc_timeout_in_ms into a
jmx mbean property
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176777#comment-13176777 ]
Brandon Williams commented on CASSANDRA-2940:
---------------------------------------------
bq. DatabaseDescriptor.setRpcTimeout(Long) changes the value of Config.rpc_timeout_in_ms (notice that my understanding is that we should keep this as it is...
I realized there may be some confusion here... Config itself should not need any changes, but DatabaseDescriptor's instance of it (conf) can be updated. There are numerous others setters in DD that do this.
> Make rpc_timeout_in_ms into a jmx mbean property
> ------------------------------------------------
>
> Key: CASSANDRA-2940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2940
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeremy Hanna
> Labels: lhf
> Attachments: trunk-CASSANDRA-2940.txt
>
>
> When using the hadoop integration especially, experimenting with rpc_timeout_in_ms is a pain if you have to restart every server in the cluster for it to take effect. This would be an improvement to make it into a jmx mbean property to set it at runtime. The yaml file could be updated separately so it would be persistent still.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira