[jira] Updated: (SHINDIG-1174) Fix ProxyHandler to configure MakeRequest correctly

["Arne Roomann-Kurrik (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Roomann-Kurrik updated SHINDIG-1174:
-----------------------------------------

    Attachment: issue116056_1.diff

Code review: http://codereview.appspot.com/116056/show

This patch fixes the error message seen when requesting proxied assets:

1.) Removes the patch to return if the parameter is empty (we could actually
leave that in, it would mean that explicitly configured parameters with no value
would be ignored for requests expecting a structured type, though)

2.) Corrects the error message when expecting a structured type.  What I don't
like about this right now is that it doesn't mention the parameter name, but
fixing that would be pretty ugly.  

3.) Allows for creating a ProxyBase with an instance of a makeRequest object
(needed for a forthcoming unit test patch).

4.) The main fix - change the defaults in ProxyBase to null instead of an empty
string, when creating a MakeRequestOptions class from the request. 

> Fix ProxyHandler to configure MakeRequest correctly
> ---------------------------------------------------
>
>                 Key: SHINDIG-1174
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1174
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>         Attachments: issue116056_1.diff
>
>
> The content proxy has a hack to enable support with the new MakeRequest class.  This hack should be removed in favor of a real solution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.