[jira] [Created] (HBASE-23038) Provide consistent and clear logging about disabling chores

["Sean Busbey (Jira)" <ji...@apache.org>]

Sean Busbey created HBASE-23038:
-----------------------------------

             Summary: Provide consistent and clear logging about disabling chores
                 Key: HBASE-23038
                 URL: https://issues.apache.org/jira/browse/HBASE-23038
             Project: HBase
          Issue Type: Improvement
          Components: master, regionserver
            Reporter: Sean Busbey


Right now if you want to disable any of our chores you can set the period to be <= 0. Sometimes, if you do this you get a nice message:
{code}
2019-09-16 22:10:16,756 INFO  [master-1:16000.activeMasterManager] master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
{code}
And sometimes you get an opaque message:
{code}
2019-09-16 22:09:45,333 INFO  [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
2019-09-16 22:09:45,340 INFO  [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
{code}
This is because sometimes we just blindly submit to ChoreService which submits to a java ScheduledExecutorService and then catches the IllegalArgumentException.

We should remove the one-offs and make it so ChoreService checks the period before accepting a submittal and produces a consistent "Foo is disabled" message.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)