You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2024/05/06 05:16:41 UTC

[PR] [fix][admin] Fix deprecated check [pulsar]

nodece opened a new pull request, #22653:
URL: https://github.com/apache/pulsar/pull/22653

   ### Motivation
   
   After migrating to picocli, which does not allow passing unknown options:
   
   ```
   bin/pulsar-admin sinks localrun --archive $PWD/connectors/pulsar-io-elastic-search-3.3.0-SNAPSHOT.nar --tenant public --namespace default --name elasticsearch-test-sink --sink-config-file $PWD/es-sink.yml --inputs elasticsearch_test
   Exception in thread "main" picocli.CommandLine$UnmatchedArgumentException: Unknown options: '--deprecatedBrokerServiceUrl', 'pulsar://localhost:6650/'
   ```
   
   The previous version had a filtering mechanism, but the implementation was incorrect.
   
   ### Modifications
   
   - Fix deprecated check
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][admin] Fix deprecated check [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22653:
URL: https://github.com/apache/pulsar/pull/22653#issuecomment-2096229592

   @lhotari Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][admin] Fix deprecated check [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22653:
URL: https://github.com/apache/pulsar/pull/22653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org