[GitHub] [incubator-superset] villebro commented on a change in pull request #8416: #8415: Prevent the database password from being exported along with the dashboards

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8416: #8415: Prevent the database password from being exported along with the dashboards
URL: https://github.com/apache/incubator-superset/pull/8416#discussion_r337675013
 
 

 ##########
 File path: superset/utils/core.py
 ##########
 @@ -283,7 +283,7 @@ def __init__(self, *args, **kwargs):
     # pylint: disable=E0202
     def default(self, o):
         try:
-            vals = {k: v for k, v in o.__dict__.items() if k != "_sa_instance_state"}
+            vals = {k: v for k, v in o.__dict__.items() if k != "_sa_instance_state" and k != 'password'}
 
 Review comment:
   a cleaner way of doing this would be ...`if k not in ("_sa_instance_state", "password")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org