[GitHub] [iotdb] ycycse commented on a diff in pull request #8941: [IOTDB-5341] The front end of eventWindow in aggregation query

["ycycse (via GitHub)" <gi...@apache.org>]

ycycse commented on code in PR #8941:
URL: https://github.com/apache/iotdb/pull/8941#discussion_r1094528483


##########
antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -475,6 +475,11 @@ groupByAttributeClause
     : TIME? LR_BRACKET (timeRange COMMA)? interval=DURATION_LITERAL (COMMA step=DURATION_LITERAL)? RR_BRACKET
     | LEVEL operator_eq INTEGER_LITERAL (COMMA INTEGER_LITERAL)*
     | TAGS LR_BRACKET identifier (COMMA identifier)* RR_BRACKET
+    | VARIATION LR_BRACKET expression (COMMA delta=INTEGER_LITERAL|realLiteral)? (COMMA keyValuePair)* RR_BRACKET

Review Comment:
   done



##########
antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -475,6 +475,11 @@ groupByAttributeClause
     : TIME? LR_BRACKET (timeRange COMMA)? interval=DURATION_LITERAL (COMMA step=DURATION_LITERAL)? RR_BRACKET
     | LEVEL operator_eq INTEGER_LITERAL (COMMA INTEGER_LITERAL)*
     | TAGS LR_BRACKET identifier (COMMA identifier)* RR_BRACKET
+    | VARIATION LR_BRACKET expression (COMMA delta=INTEGER_LITERAL|realLiteral)? (COMMA keyValuePair)* RR_BRACKET
+    ;
+
+keyValuePair

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org