You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/12/01 04:08:44 UTC

[PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

yiguolei opened a new pull request, #27860:
URL: https://github.com/apache/doris/pull/27860

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835519902

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835452690

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835455117

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835516251

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835516590

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit e578719a16af925a3893ba874402453a7dda6937, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4887	4629	4611	4611
   q2	364	148	161	148
   q3	1508	1343	1269	1269
   q4	1141	973	952	952
   q5	3214	3205	3201	3201
   q6	255	133	128	128
   q7	1015	520	545	520
   q8	2271	2233	2212	2212
   q9	6938	6991	6971	6971
   q10	3305	3329	3345	3329
   q11	344	215	203	203
   q12	354	216	214	214
   q13	5884	3922	3863	3863
   q14	263	214	209	209
   q15	589	535	524	524
   q16	440	395	404	395
   q17	1020	634	591	591
   q18	7883	7937	7223	7223
   q19	1563	1545	1567	1545
   q20	551	310	395	310
   q21	3419	2901	2914	2901
   q22	375	300	309	300
   Total cold run time: 47583 ms
   Total hot run time: 41619 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4606	4537	4572	4537
   q2	322	201	228	201
   q3	3731	3727	3706	3706
   q4	2514	2496	2493	2493
   q5	6091	6087	6078	6078
   q6	242	124	124	124
   q7	2681	1994	1973	1973
   q8	3719	3664	3674	3664
   q9	9539	9492	9441	9441
   q10	4039	4116	4121	4116
   q11	622	511	460	460
   q12	805	642	627	627
   q13	4344	3608	3627	3608
   q14	277	239	245	239
   q15	595	531	539	531
   q16	508	472	451	451
   q17	2100	2053	2080	2053
   q18	9498	8695	8845	8695
   q19	1833	1777	1767	1767
   q20	2301	1990	1969	1969
   q21	7242	6832	7082	6832
   q22	669	558	569	558
   Total cold run time: 68278 ms
   Total hot run time: 64123 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835657468

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 39c9901c1b0274cb6c2d572007941d2255515db0, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4901	4658	4648	4648
   q2	358	164	161	161
   q3	1507	1308	1274	1274
   q4	1150	979	920	920
   q5	3235	3250	3232	3232
   q6	255	134	133	133
   q7	1020	517	560	517
   q8	2267	2250	2239	2239
   q9	6991	6952	6926	6926
   q10	3267	3343	3356	3343
   q11	340	215	212	212
   q12	355	216	216	216
   q13	4612	3891	3902	3891
   q14	250	218	222	218
   q15	591	550	526	526
   q16	436	401	394	394
   q17	1032	651	558	558
   q18	7638	7327	8286	7327
   q19	1568	1570	1526	1526
   q20	608	298	280	280
   q21	3433	2892	2930	2892
   q22	369	304	315	304
   Total cold run time: 46183 ms
   Total hot run time: 41737 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4614	4613	4626	4613
   q2	327	219	229	219
   q3	3710	3708	3705	3705
   q4	2523	2510	2508	2508
   q5	6092	6102	6080	6080
   q6	246	126	122	122
   q7	2678	1960	1967	1960
   q8	3769	3703	3718	3703
   q9	9518	9449	9424	9424
   q10	4042	4138	4152	4138
   q11	644	582	493	493
   q12	816	621	625	621
   q13	4351	3611	3622	3611
   q14	276	244	244	244
   q15	596	536	543	536
   q16	537	480	491	480
   q17	2087	2067	2113	2067
   q18	9445	8898	8867	8867
   q19	1823	1787	1778	1778
   q20	2318	1996	1983	1983
   q21	7300	6948	6840	6840
   q22	622	590	583	583
   Total cold run time: 68334 ms
   Total hot run time: 64575 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835452723

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835672970

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.04 seconds
    stream load tsv:          562 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17167131231 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835482486

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.13 seconds
    stream load tsv:          563 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.5 seconds inserted 10000000 Rows, about 350K ops/s
    storage size: 17167525426 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #27860:
URL: https://github.com/apache/doris/pull/27860#issuecomment-1835526300

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [bugfix](mergeprofile) ignore null profile to avoid bug [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27860:
URL: https://github.com/apache/doris/pull/27860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org