You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/30 20:49:40 UTC

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params

eric-haibin-lin commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params
URL: https://github.com/apache/incubator-mxnet/pull/15688#discussion_r308935916
 
 

 ##########
 File path: src/operator/tensor/matrix_op.cc
 ##########
 @@ -763,7 +763,7 @@ parameter values:
 .add_arguments(ClipParam::__FIELDS__());
 
 NNVM_REGISTER_OP(_backward_clip)
-.set_num_inputs(1)
+.set_num_inputs(2)
 
 Review comment:
   I'm surprised to see this was not caught previously. Is there any unit test to unvail this bug? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services