Bug in way access file handles comments

[bd...@micron.com]

I'd like to see whether this is considered a bug or not.

Example access file:

# my project access control
[myproj:/mydirectory]
sally = rw
harry = r   # don't let harry write to this directory

Using the Apache module for access, and a svn (ver 1.2.3) client one is
able to write (commit changes) to the directory mydirectory as the user
harry.  It turns out that if the "w" from the comment, is removed as "#
don't let harry rite to this directory", then harry only has read access
as expected.

Shouldn't the rest of the line be ignored after the # sign?

Thanks,
Brian

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Bug in way access file handles comments

[Garrett Rooney <ro...@electricjellyfish.net>]

On 3/17/06, bdwalker@micron.com <bd...@micron.com> wrote:
> I'd like to see whether this is considered a bug or not.
>
> Example access file:
>
> # my project access control
> [myproj:/mydirectory]
> sally = rw
> harry = r   # don't let harry write to this directory
>
> Using the Apache module for access, and a svn (ver 1.2.3) client one is
> able to write (commit changes) to the directory mydirectory as the user
> harry.  It turns out that if the "w" from the comment, is removed as "#
> don't let harry rite to this directory", then harry only has read access
> as expected.
>
> Shouldn't the rest of the line be ignored after the # sign?

Sorry, this has been sitting in my inbox waiting for me to get a
chance to look at it, but I just got around to it.  I do think this is
a problem, and I'm working on a patch, but I have to figure out the
correct place to fix it (I'd assume that the config parser code should
be stripping this data, and that's what my current patch does, but I'm
not sure if our compat guidelines let us change that behavior, so I
may need to fix it in the authz code).  Did you end up filing an issue
about it?  I looked around, but could not find one.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org