You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/25 15:30:20 UTC
[jira] [Commented] (FLINK-4329) Fix Streaming File Source
Timestamps/Watermarks Handling
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520984#comment-15520984 ]
ASF GitHub Bot commented on FLINK-4329:
---------------------------------------
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2546
[FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink fix_ingestion_time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2546
----
commit 1b15b77b80334adf869714937dbfa8d8b7c2e12f
Author: kl0u <kk...@gmail.com>
Date: 2016-08-25T15:38:49Z
[FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling
----
> Fix Streaming File Source Timestamps/Watermarks Handling
> --------------------------------------------------------
>
> Key: FLINK-4329
> URL: https://issues.apache.org/jira/browse/FLINK-4329
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Kostas Kloudas
> Fix For: 1.2.0, 1.1.3
>
>
> The {{ContinuousFileReaderOperator}} does not correctly deal with watermarks, i.e. they are just passed through. This means that when the {{ContinuousFileMonitoringFunction}} closes and emits a {{Long.MAX_VALUE}} that watermark can "overtake" the records that are to be emitted in the {{ContinuousFileReaderOperator}}. Together with the new "allowed lateness" setting in window operator this can lead to elements being dropped as late.
> Also, {{ContinuousFileReaderOperator}} does not correctly assign ingestion timestamps since it is not technically a source but looks like one to the user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)