[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2738: ARTEMIS-2407 Large message file not deleted if broker crashes between page deleted and pending large message written

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2738: ARTEMIS-2407 Large message file not deleted if broker crashes between page deleted and pending large message written
URL: https://github.com/apache/activemq-artemis/pull/2738#discussion_r303666042
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ##########
 @@ -352,11 +353,15 @@ public boolean delete(final PagedMessage[] messages) throws Exception {
                // Because the large-message may be linked to another message
                // or it may still being delivered even though it has been acked already
                lmsg.decrementDelayDeletionCount();
+               largeMessageIds.add(lmsg.getMessageID());
             }
          }
       }
 
       try {
+         if (!storageManager.getContext().waitCompletion(5000)) {
+            logger.info("Time out waiting for large messages" + largeMessageIds + ", may be not deleted if crashed");
 
 Review comment:
   please create a paramatised logger with a log code, ActiveMQServerLogger.LOGGER

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services