You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nssalian (via GitHub)" <gi...@apache.org> on 2026/09/20 22:01:21 UTC
[I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
nssalian opened a new issue, #18191:
URL: https://github.com/apache/iceberg/issues/18191
## Feature Request / Improvement
The source release tarball bundles third-party assets under `site/docs/assets/` that aren't listed in the root `LICENSE` and whose license texts aren't included:
| File | Origin | License in file |
|---|---|---|
| `stylesheets/bootstrap-grid.css` | Bootstrap Grid v5.3.0-alpha3 | copyright + MIT link, no MIT text |
| `stylesheets/termynal.css` | termynal (Ines Montani) | `@license MIT`, no MIT text |
| `javascript/termynal.js` | termynal (Ines Montani) | `@license MIT`, no MIT text |
| `javascript/lottie-player.js` | Lottie player (minified bundle) | no banner; embeds `BSD-3-Clause` + Google/Microsoft copyrights |
(`stylesheets/bootstrap-buttons.css` looks Bootstrap-derived but has no header, so its origin is worth confirming.)
This isn't a regression. The same assets ship in 1.9.0/1.10.0/1.11.0. It was raised on the 1.12.0 RC0 vote. They got in because `dev/source-release.sh` uses `git archive`, and `.gitattributes` export-ignores `/build`, `/examples`, `/docs` but not `site/`.
Reproduced:
```bash
git archive dec392570a88e45ac3a417a487dd72f9bdb629d5 --worktree-attributes --prefix apache-iceberg-1.12.0/ -o /tmp/repro.tar.gz
tar tzf /tmp/repro.tar.gz | grep site/docs/assets/
```
Possible fixes:
- add `/site/docs/** export-ignore` to `.gitattributes` (these aren't needed to build from source)
- or include the license texts and add root `LICENSE` entries
Refs: https://infra.apache.org/licensing-howto.html . [Prior discussion thread](https://lists.apache.org/thread/hstl6z6qp55hxgdlljpc5xg8wc3kq800)
## Query engine
Other (source release / build tooling)
## Willingness to contribute
- [ ] I can contribute this improvement/feature independently
- [ ] I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- [x] I cannot contribute this improvement/feature at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #18191:
URL: https://github.com/apache/iceberg/issues/18191#issuecomment-5753104429
I guess just ignore? I'm not quite sure on this because I'm pretty sure we should be doing licensing for everything we ship (including docs) but it seems like we are doing that already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on issue #18191:
URL: https://github.com/apache/iceberg/issues/18191#issuecomment-5754220930
Should be an easy fix. I'll put up a PR. I'll wait for the vote to close so we can check if more fixes are needed before cutting another RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #18191:
URL: https://github.com/apache/iceberg/issues/18191#issuecomment-5763506691
Thanks @nssalian I merged #18193
Might be a good idea to notify the voting thread so people aren't spending time validating an RC thats getting cancelled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #18191: Source release bundles third-party doc-site assets not accounted for in LICENSE
URL: https://github.com/apache/iceberg/issues/18191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #18191:
URL: https://github.com/apache/iceberg/issues/18191#issuecomment-5753983870
I think we should just ignore those files and not package them. We currently do the same for the files under `docs/**` https://github.com/apache/iceberg/blob/e45573b61f9981062a0f00c286086f2856d734de/.gitattributes#L30-L31
Lets just ignore everything under `site/**`
And I think this might mean we need a new RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Source release bundles third-party doc-site assets not accounted for in LICENSE [iceberg]
Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on issue #18191:
URL: https://github.com/apache/iceberg/issues/18191#issuecomment-5763581163
> Might be a good idea to notify the voting thread so people aren't spending time validating an RC thats getting cancelled.
Done. Was waiting for this to be merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org