[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #341: Don't preconfig, clean or distclean when it's not necessary

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #341:
URL: https://github.com/apache/incubator-nuttx-apps/pull/341#discussion_r460338878



##########
File path: Directory.mk
##########
@@ -35,36 +35,30 @@
 
 include $(APPDIR)/Make.defs
 
-# Sub-directories
+# Sub-directories that have been built.
 
-SUBDIRS = $(dir $(wildcard */Makefile))
+CLEANSUBDIRS     = $(dir $(wildcard */.built))
+DISTCLEANSUBDIRS = $(dir $(wildcard */.depend))
 
 all: nothing
 
-.PHONY: nothing context depend clean distclean
+.PHONY: nothing clean distclean
 
-$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),preconfig)))
-$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),context)))
-$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),depend)))
-$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),clean)))
-$(foreach SDIR, $(SUBDIRS), $(eval $(call SDIR_template,$(SDIR),distclean)))
+$(foreach SDIR, $(CLEANSUBDIRS), $(eval $(call SDIR_template,$(SDIR),clean)))
+$(foreach SDIR, $(DISTCLEANSUBDIRS), $(eval $(call SDIR_template,$(SDIR),distclean)))

Review comment:
       Should these be moved to a make target so they can use parallelism of '-j'? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org