You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/06/01 02:31:29 UTC

[GitHub] spark pull request #19602: [SPARK-22384][SQL] Refine partition pruning when ...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19602#discussion_r192286303
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
    @@ -657,18 +656,30 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
     
         val useAdvanced = SQLConf.get.advancedPartitionPredicatePushdownEnabled
     
    +    object ExtractAttribute {
    +      def unapply(expr: Expression): Option[Attribute] = {
    +        expr match {
    +          case attr: Attribute => Some(attr)
    +          case cast @ Cast(child, dt, _) if !Cast.mayTruncate(child.dataType, dt) => unapply(child)
    --- End diff --
    
    nit: `cast @ ` is not needed here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org