[GitHub] [flink] luoyuxia commented on a change in pull request #19315: [hive] support distinct from

[GitBox <gi...@apache.org>]

luoyuxia commented on a change in pull request #19315:
URL: https://github.com/apache/flink/pull/19315#discussion_r841057587



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -445,14 +445,24 @@ object ScalarOperatorGens {
     }
   }
 
+  def generateIsDistinctFrom(
+      ctx: CodeGeneratorContext,
+      left: GeneratedExpression,
+      right: GeneratedExpression)
+    : GeneratedExpression = {
+    generateAnd(
+      generateOr(generateIsNotNull(left), generateIsNotNull(right)),
+      generateIsNotTrue(generateEquals(ctx, left, right)))
+  }
+
   def generateIsNotDistinctFrom(
       ctx: CodeGeneratorContext,
       left: GeneratedExpression,
       right: GeneratedExpression)
     : GeneratedExpression = {
     generateOr(
       generateAnd(generateIsNull(left), generateIsNull(right)),
-      generateEquals(ctx, left, right))
+      generateIsTrue(generateEquals(ctx, left, right)))

Review comment:
       generateEquals may produce UNKNOWN, so we should change it to generateIsTrue(generateEquals).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org