You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/28 16:56:25 UTC
[GitHub] [hudi] xccui opened a new pull request, #7575: [MINOR] Set engine when creating meta writer config
xccui opened a new pull request, #7575:
URL: https://github.com/apache/hudi/pull/7575
### Change Logs
Properly set engine type when creating `MetadataWriteConfig` from `HoodieWriteConfig`.
### Impact
Won't get warning `Embedded timeline server is disabled, fallback to use direct marker type for spark`
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [x] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xccui commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
xccui commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1372402721
Hi @codope, ptal, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1366814849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1367002590
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024",
"triggerID" : "1366933043",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xccui commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
xccui commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1367387566
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #7575:
URL: https://github.com/apache/hudi/pull/7575#discussion_r1058576195
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -242,6 +242,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
// Create the write config for the metadata table by borrowing options from the main write config.
HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
+ .withEngineType(writeConfig.getEngineType())
Review Comment:
Thanks for the change! So, this warning is only shown for metadata table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1366899172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #7575:
URL: https://github.com/apache/hudi/pull/7575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xccui commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
xccui commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1366933043
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1367491053
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024",
"triggerID" : "1366933043",
"triggerType" : "MANUAL"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14039",
"triggerID" : "1367387566",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14039)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1366811719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1367390548
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024",
"triggerID" : "1366933043",
"triggerType" : "MANUAL"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14039",
"triggerID" : "1367387566",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14039)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xccui commented on a diff in pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
xccui commented on code in PR #7575:
URL: https://github.com/apache/hudi/pull/7575#discussion_r1058616932
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -242,6 +242,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
// Create the write config for the metadata table by borrowing options from the main write config.
HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
+ .withEngineType(writeConfig.getEngineType())
Review Comment:
Yes. It only happens when `FlinkOptions.METADATA_ENABLED` was set to `true`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -242,6 +242,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
// Create the write config for the metadata table by borrowing options from the main write config.
HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
+ .withEngineType(writeConfig.getEngineType())
Review Comment:
Yes. It only happened when `FlinkOptions.METADATA_ENABLED` was set to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7575: [MINOR] Set engine when creating meta write config
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7575:
URL: https://github.com/apache/hudi/pull/7575#issuecomment-1366936944
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021",
"triggerID" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"triggerType" : "PUSH"
}, {
"hash" : "a35c9c05aec17c775e39c0472fbe952178b2f60e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024",
"triggerID" : "1366933043",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a35c9c05aec17c775e39c0472fbe952178b2f60e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14021) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org