You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/03 03:04:20 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6245: Metrics facade spi design in Sharding-Proxy

codecov-commenter commented on pull request #6245:
URL: https://github.com/apache/shardingsphere/pull/6245#issuecomment-653313303


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=h1) Report
   > Merging [#6245](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/91cee9bc26db146ba0f090d053e2bebf82bb9bd5&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `52.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6245/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6245      +/-   ##
   ============================================
   - Coverage     52.74%   52.69%   -0.06%     
   - Complexity      444      447       +3     
   ============================================
     Files          1199     1202       +3     
     Lines         21341    21375      +34     
     Branches       3803     3809       +6     
   ============================================
   + Hits          11257    11263       +6     
   - Misses         9369     9398      +29     
   + Partials        715      714       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rol/panel/spi/engine/ControlPanelFacadeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jb250cm9sLXBhbmVsLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29udHJvbC9wYW5lbC9zcGkvZW5naW5lL0NvbnRyb2xQYW5lbEZhY2FkZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...l/panel/spi/engine/MetricsHandlerFacadeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jb250cm9sLXBhbmVsLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29udHJvbC9wYW5lbC9zcGkvZW5naW5lL01ldHJpY3NIYW5kbGVyRmFjYWRlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ation/core/schema/OrchestrationSchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtc2NoZW1hL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvc2NoZW1hL09yY2hlc3RyYXRpb25TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `19.35% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/frontend/command/CommandExecutorTask.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvY29tbWFuZC9Db21tYW5kRXhlY3V0b3JUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../frontend/netty/FrontendChannelInboundHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvbmV0dHkvRnJvbnRlbmRDaGFubmVsSW5ib3VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ingsphere/metrics/facade/MetricsTrackerFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1tZXRyaWNzL3NoYXJkaW5nc3BoZXJlLW1ldHJpY3MtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tZXRyaWNzL2ZhY2FkZS9NZXRyaWNzVHJhY2tlckZhY2FkZS5qYXZh) | `72.41% <72.22%> (-13.80%)` | `1.00 <1.00> (+1.00)` | :arrow_down: |
   | [...dingsphere/proxy/backend/metrics/MetricsUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9tZXRyaWNzL01ldHJpY3NVdGlscy5qYXZh) | `61.11% <75.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ardingsphere/metrics/facade/MetricsInitFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1tZXRyaWNzL3NoYXJkaW5nc3BoZXJlLW1ldHJpY3MtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tZXRyaWNzL2ZhY2FkZS9NZXRyaWNzSW5pdEZhY2FkZS5qYXZh) | `97.22% <97.22%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/6245/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=footer). Last update [91cee9b...0b77767](https://codecov.io/gh/apache/shardingsphere/pull/6245?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org