You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/16 06:34:38 UTC
Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3656
Repository: mesos
Description
-------
Windows: Add Windows support to `process/socket.hpp`.
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
Diff: https://reviews.apache.org/r/39377/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 16, 2015, 8:03 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 20
> > <https://reviews.apache.org/r/39377/diff/2/?file=1100126#file1100126line20>
> >
> > Is this include used?
> >
> > I didn't see (an obvious) use through `socket.hpp`, `socket.cpp`, or `poll_socket.cpp`.
Yeah. This dependency is used implicitly throughout the agent codebase, and if you pull it out, then you would have to add it directly to all of those files (maybe 6 of them).
Arguably you _should_ do this but I aimed for a minimal diff instead (1) because I didn't want to cause waves, and (2) because I think that refactoring headers to be more sane is a much bigger task that we should consider just doing as part of a "clean up the debt" hackathon or something.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review102974
-----------------------------------------------------------
On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39377/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 7:50 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3656
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Add Windows support to `process/socket.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
> 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
>
> Diff: https://reviews.apache.org/r/39377/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review102974
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/socket.hpp (line 20)
<https://reviews.apache.org/r/39377/#comment160804>
Is this include used?
I didn't see (an obvious) use through `socket.hpp`, `socket.cpp`, or `poll_socket.cpp`.
- Joseph Wu
On Oct. 16, 2015, 12:50 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39377/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 12:50 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3656
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Add Windows support to `process/socket.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
> 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
>
> Diff: https://reviews.apache.org/r/39377/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/#review103273
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/socket.hpp (lines 30 - 32)
<https://reviews.apache.org/r/39377/#comment161264>
I think elsewhere we didn't leave a new line here?
3rdparty/libprocess/src/poll_socket.cpp (lines 17 - 18)
<https://reviews.apache.org/r/39377/#comment161265>
we usually include `stout` after `process` right?
- Joris Van Remoortere
On Oct. 19, 2015, 11:26 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39377/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 11:26 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3656
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Add Windows support to `process/socket.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
> 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
>
> Diff: https://reviews.apache.org/r/39377/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 11:26 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3656
Repository: mesos
Description
-------
Windows: Add Windows support to `process/socket.hpp`.
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
Diff: https://reviews.apache.org/r/39377/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39377: Windows: Add Windows support to
`process/socket.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39377/
-----------------------------------------------------------
(Updated Oct. 16, 2015, 7:50 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3628, MESOS-3649 and MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3656
Repository: mesos
Description
-------
Windows: Add Windows support to `process/socket.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp 4b2597f617fc4072144c9666a378d4ffad53a592
3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
Diff: https://reviews.apache.org/r/39377/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer