[jira] [Commented] (CASSANDRA-10202) simplify CommitLogSegmentManager

["Ariel Weisberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330127#comment-15330127 ] 

Ariel Weisberg commented on CASSANDRA-10202:
--------------------------------------------

Not super excited about including an intrusive concurrent linked list implementation. It includes no tests including stress tests of concurrent correctness. I looked at it and I think it works, but then again I have written a concurrent linked list that looked like it worked (and did in the application), but failed during stress tests in JMH.

Why is the replay limit stuff necessary? Seems like it replays everything since the limit is set to be higher then anything that is available.

I reviewed it and as far as I can tell it looks like it does what it did before so +1 to that.

> simplify CommitLogSegmentManager
> --------------------------------
>
>                 Key: CASSANDRA-10202
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10202
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Jonathan Ellis
>            Assignee: Branimir Lambov
>            Priority: Minor
>
> Now that we only keep one active segment around we can simplify this from the old recycling design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)