You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Thomas Koch <th...@koch.ro> on 2011/09/07 13:16:27 UTC
Review Request: some cleanup and improvements for zooinspector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1733/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-756.
https://issues.apache.org/jira/browse/ZOOKEEPER-756
Diffs
-----
src/contrib/zooinspector/NOTICE.txt 059bdc1
src/contrib/zooinspector/TODO PRE-CREATION
src/contrib/zooinspector/build.xml bf757d7
src/contrib/zooinspector/config/defaultConnectionSettings.cfg 806789e
src/contrib/zooinspector/config/defaultNodeVeiwers.cfg 38fe9a8
src/contrib/zooinspector/config/defaultNodeViewers.cfg PRE-CREATION
src/contrib/zooinspector/icons/edtsrclkup_co.gif 94eedf6
src/contrib/zooinspector/icons/file_obj.gif b226e41
src/contrib/zooinspector/icons/fldr_obj.gif 51e703b
src/contrib/zooinspector/icons/info_obj.gif 2da001e
src/contrib/zooinspector/icons/jspdecl.gif 35f48ef
src/contrib/zooinspector/icons/launch_run.gif 57f4102
src/contrib/zooinspector/icons/launch_stop.gif fbf1686
src/contrib/zooinspector/icons/new_con.gif 9d05088
src/contrib/zooinspector/icons/refresh.gif 3ca04d0
src/contrib/zooinspector/icons/save_edit.gif 499dd0c
src/contrib/zooinspector/icons/search_next.gif 072b184
src/contrib/zooinspector/icons/search_prev.gif 0716475
src/contrib/zooinspector/icons/trash.gif 5f47780
src/contrib/zooinspector/lib/jtoaster-1.0.4.jar aaf3f6e
src/contrib/zooinspector/licences/epl-v10.html fd39122
src/contrib/zooinspector/src/java/com/nitido/utils/toaster/Toaster.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/ZooInspector.java 28a4b21
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/IconResource.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/Toolbar.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorAboutDialog.java 1acb16a
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorIconResources.java cc925a9
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorNodeViewersDialog.java 66125fd
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorPanel.java c2d0fac
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorTreeViewer.java b49be2d
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeViewerData.java 9dd0f38
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/status/info.png PRE-CREATION
Diff: https://reviews.apache.org/r/1733/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-756 some cleanup and improvements for
zooinspector
Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1733/
-----------------------------------------------------------
(Updated 2011-09-14 22:18:03.263608)
Review request for zookeeper.
Summary (updated)
-------
.
This addresses bug ZOOKEEPER-756.
https://issues.apache.org/jira/browse/ZOOKEEPER-756
Diffs
-----
src/contrib/zooinspector/NOTICE.txt 059bdc1
src/contrib/zooinspector/TODO PRE-CREATION
src/contrib/zooinspector/build.xml bf757d7
src/contrib/zooinspector/config/defaultConnectionSettings.cfg 806789e
src/contrib/zooinspector/config/defaultNodeVeiwers.cfg 38fe9a8
src/contrib/zooinspector/config/defaultNodeViewers.cfg PRE-CREATION
src/contrib/zooinspector/icons/edtsrclkup_co.gif 94eedf6
src/contrib/zooinspector/icons/file_obj.gif b226e41
src/contrib/zooinspector/icons/fldr_obj.gif 51e703b
src/contrib/zooinspector/icons/info_obj.gif 2da001e
src/contrib/zooinspector/icons/jspdecl.gif 35f48ef
src/contrib/zooinspector/icons/launch_run.gif 57f4102
src/contrib/zooinspector/icons/launch_stop.gif fbf1686
src/contrib/zooinspector/icons/new_con.gif 9d05088
src/contrib/zooinspector/icons/refresh.gif 3ca04d0
src/contrib/zooinspector/icons/save_edit.gif 499dd0c
src/contrib/zooinspector/icons/search_next.gif 072b184
src/contrib/zooinspector/icons/search_prev.gif 0716475
src/contrib/zooinspector/icons/trash.gif 5f47780
src/contrib/zooinspector/lib/jtoaster-1.0.4.jar aaf3f6e
src/contrib/zooinspector/licences/epl-v10.html fd39122
src/contrib/zooinspector/src/java/com/nitido/utils/toaster/Toaster.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/ZooInspector.java 28a4b21
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/IconResource.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/Toolbar.java PRE-CREATION
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorAboutDialog.java 1acb16a
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorIconResources.java cc925a9
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorNodeViewersDialog.java 66125fd
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorPanel.java c2d0fac
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/ZooInspectorTreeViewer.java b49be2d
src/contrib/zooinspector/src/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeViewerData.java 9dd0f38
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/16x16/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/22x22/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/24x24/status/info.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/add.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-new.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/document-save.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/down.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-start.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/media-playback-stop.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/remove.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/up.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/actions/view-refresh.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/mimetypes/text-x-generic.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/folder.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/places/user-trash.png PRE-CREATION
src/contrib/zooinspector/src/main/resources/icons/Tango/32x32/status/info.png PRE-CREATION
Diff: https://reviews.apache.org/r/1733/diff
Testing
-------
Thanks,
Thomas