You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/05 06:16:13 UTC
[GitHub] [flink] twalthr commented on a change in pull request #11969: [FLINK-17489][core] Support any kind of array in StringUtils.arrayAwareToString()
twalthr commented on a change in pull request #11969:
URL: https://github.com/apache/flink/pull/11969#discussion_r419884235
##########
File path: flink-core/src/test/java/org/apache/flink/util/StringUtilsTest.java
##########
@@ -39,21 +40,26 @@ public void testControlCharacters() {
}
@Test
- public void testArrayOfBytesArray() {
- byte[][] expectedArray = new byte[][]{
- {1, -97, 49, 74 },
- {2, -92, 48, 73 }
- };
+ public void testArrayAwareToString() {
Review comment:
Currently, every test method tests one util method. I would like to keep it as it is, if that's ok. I think it is fine to fail early if the first assertion fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org