You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2018/05/31 08:24:15 UTC

svn commit: r1832585 - in /tomcat/trunk: java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

Author: kfujino
Date: Thu May 31 08:24:15 2018
New Revision: 1832585

URL: http://svn.apache.org/viewvc?rev=1832585&view=rev
Log:
When decoding of path parameter failed, make sure to throw DecodeException instead of throwing ArrayIndexOutOfBoundsException.

Modified:
    tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1832585&r1=1832584&r2=1832585&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Thu May 31 08:24:15 2018
@@ -645,6 +645,7 @@ public class PojoMethodMapping {
                                     "pojoMethodMapping.decodePathParamFail",
                                     valueString, pathParam.getType()), e);
                     params = new Object[] { de };
+                    break;
                 }
                 params[entry.getKey().intValue()] = value;
             }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832585&r1=1832584&r2=1832585&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May 31 08:24:15 2018
@@ -217,6 +217,11 @@
       <update>
         Use NIO2 API for websockets writes. (remm)
       </update>
+      <fix>
+        When decoding of path parameter failed, make sure to throw
+        <code>DecodeException</code> instead of throwing
+        <code>ArrayIndexOutOfBoundsException</code>. (kfujino)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Web applications">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org