[jira] [Commented] (LUCENE-5404) Add support to get number of entries a Suggester Lookup was built with and minor refactorings

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875611#comment-13875611 ] 

Michael McCandless commented on LUCENE-5404:
--------------------------------------------

Thanks Areek, this looks great.

Can we name the method .getCount() instead, just to make it clear it's "just" getting a simple property?  .count() makes it sound like it may go off and do a bunch of work to count something...

> Add support to get number of entries a Suggester Lookup was built with and minor refactorings
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5404
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5404
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Areek Zillur
>             Fix For: 5.0, 4.7
>
>         Attachments: LUCENE-5404.patch
>
>
> It would be nice to be able to tell the number of entries a suggester lookup was built with. This would let components using lookups to keep some stats regarding how many entries were used to build a lookup.
> Additionally, Dictionary could use InputIterator rather than the BytesRefIteratator, as most of the implmentations now use it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org