You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/01 06:49:17 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1330: MINIFICPP-1832 Integrate first batch of clang-tidy checks in CI

lordgamez commented on code in PR #1330:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1330#discussion_r886373092


##########
extensions/libarchive/FocusArchiveEntry.cpp:
##########
@@ -176,15 +176,13 @@ int64_t FocusArchiveEntry::ReadCallback::operator()(const std::shared_ptr<io::Ba
   archive_read_support_filter_all(inputArchive);
 
   // Read each item in the archive
-  int res;
-
-  if ((res = archive_read_open(inputArchive, &data, ok_cb, read_cb, ok_cb))) {
+  if ((archive_read_open(inputArchive, &data, ok_cb, read_cb, ok_cb))) {

Review Comment:
   I think it's not, removed them in e6aea67ca0ead9f8476070cf2d908650baae1b6b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org