[jira] [Commented] (FLINK-7349) Only execute checkstyle in one build profile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110666#comment-16110666 ] 

ASF GitHub Bot commented on FLINK-7349:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4460

    [FLINK-7349] [travis] Only execute checkstyle in misc profile

    ## What is the purpose of the change
    
    Improve travis build times by skipping redundant checkstyle executions.
    
    ## Brief change log
    
      - refactor mvn configuration in travis watchdog script
      - add `-Dcheckstyle.skip=true` to core/libraries/connector/tests profile options
    
    
    ## Verifying this change
    
    Add a checkstyle violation and let it run of travis, it should only fail in 1 profile (i.e. 2 builds)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4460
    
----
commit 4730355b9efa4169f4739681999c16000d9eb3bd
Author: zentol <ch...@apache.org>
Date:   2017-08-02T10:05:56Z

    [FLINK-7349] [travis] Only execute checkstyle in misc profile

----


> Only execute checkstyle in one build profile
> --------------------------------------------
>
>                 Key: FLINK-7349
>                 URL: https://issues.apache.org/jira/browse/FLINK-7349
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle, Travis
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> We can save some time in 4/5 build profiles by skipping checkstyle. One of the build profiles builds flink completely and would suffice as a check.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)