You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Jira)" <ji...@apache.org> on 2019/11/15 13:15:00 UTC
[jira] [Comment Edited] (DISPATCH-1482) image problems in user
guide on website and local builds
[ https://issues.apache.org/jira/browse/DISPATCH-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974261#comment-16974261 ]
Robbie Gemmell edited comment on DISPATCH-1482 at 11/15/19 1:14 PM:
--------------------------------------------------------------------
I also came to realise that the source dirs for the books do have symlinks for the images up to the parent dir images folder. The site scripts couldnt handle the symlink though, and the symlink isnt copied into the build output either, hence running 'make docs' gets you output which doesnt show the images as described in the description originally. Manually building in the book source dir presumably would then give functional output.
Aside, is the images being symlinked this way due to being used in 'old-user-guide' still? If so it seems long overdue to delete that and remove the need.
was (Author: gemmellr):
I also came to realise that the source dirs for the books do have symlinks for the images up to the parent dir images folder. The symlink isnt copied into the build output though, hence running 'make docs' gets you output which doesnt show the images as described in the description. Manually building in the book source dir presumably would then give functional output.
Aside, is the images being symlinked this way due to being used in 'old-user-guide' still? If so it seems long overdue to delete that and remove the need.
> image problems in user guide on website and local builds
> --------------------------------------------------------
>
> Key: DISPATCH-1482
> URL: https://issues.apache.org/jira/browse/DISPATCH-1482
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Documentation, Website
> Affects Versions: 1.9.0
> Reporter: Robbie Gemmell
> Priority: Minor
>
> On the website, the images in the user guide are shown at their full size and so emerge ridiculously oversized, flowing off to the side and requiring scrolling to even see it all. This makes them hard to even fully visualise and impedes their usefullness (plus makes the page unsightly overall). E.g see images at http://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#routing
> In a local build from master, the same images dont even display in the user guide page at all, as they are referenced by the html as being in an 'images' subdir of the page location, but the images dir is actually in the parent dir so they are not found.
> I thought perhaps the website update scripts for dispatch were compensating for the above dir issues at the point they are run, but seems not. Rather, on trying to do a fresh build of the site pages for 1.9.0 the process failed entirely as the site scripts look for an 'images' subdir, but that doesnt exist per above, and also further as in 1.9.0 the dir was named '_images' and not 'images', having been renamed over a year ago, and only very recently changed back to 'images' again on master. The local build should be make to have working images, and the website scripts for dispatch should be updated to use the correct dir whatever it may be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org