You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "stillalex (via GitHub)" <gi...@apache.org> on 2023/05/25 17:25:14 UTC
[GitHub] [solr] stillalex opened a new pull request, #1666: SOLR-16720: Defer PKI header creation to send-time
stillalex opened a new pull request, #1666:
URL: https://github.com/apache/solr/pull/1666
https://issues.apache.org/jira/browse/SOLR-16720
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Attempting to fix failures on SOLR-16720 @gerlowskija's PR https://github.com/apache/solr/pull/1495, so contribution is heavily inspired by that PR. I think I found the reason it was failing, opening another PR for validation.
I think failures were due to extra fallback to getUser() on the onBegin -> generateToken. this should not happen as everything was already setup when the `onQueued` method was called.
I used the failure seed as a starting point, and now it passes
```
./gradlew test --tests JWTAuthPluginIntegrationTest.testMetrics -Dtests.seed=8938961115F4C519 -Dtests.multiplier=3 -Dtests.locale=tr-TR -Dtests.timezone=Pacific/Niue -Dtests.asserts=true -Dtests.file.encoding=UTF-8
```
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1666: SOLR-16720: Defer PKI header creation to send-time
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1666:
URL: https://github.com/apache/solr/pull/1666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1666: SOLR-16720: Defer PKI header creation to send-time
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #1666:
URL: https://github.com/apache/solr/pull/1666#issuecomment-1563262822
mentioning PR https://github.com/apache/solr/pull/1495 again, GH did not seem to link it to the other one correctly just by the description only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1666: SOLR-16720: Defer PKI header creation to send-time
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #1666:
URL: https://github.com/apache/solr/pull/1666#issuecomment-1563260245
@gerlowskija please take a look and let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1666: SOLR-16720: Defer PKI header creation to send-time
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1666:
URL: https://github.com/apache/solr/pull/1666#issuecomment-1564562943
Good catch on the test failure. Tests/check pass for me locally, will merge shortly and let Jenkins chew on it through the weekend before backporting.
Thanks Alex!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org