[GitHub] [hudi] danny0405 commented on a change in pull request #4861: [HUDI-3461] The archived timeline for flink streaming reader should n…

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #4861:
URL: https://github.com/apache/hudi/pull/4861#discussion_r810978819



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -117,12 +130,19 @@ public static Path getArchiveLogPath(String archiveFolder) {
   }
 
   public void loadInstantDetailsInMemory(String startTs, String endTs) {
-    loadInstants(startTs, endTs);
+    setInstants(loadInstants(startTs, endTs));
   }
 
   public void loadCompletedInstantDetailsInMemory() {
-    loadInstants(null, true,
+    final List<HoodieInstant> instants = loadInstants(null, true,
         record -> HoodieInstant.State.COMPLETED.toString().equals(record.get(ACTION_STATE).toString()));
+    setInstants(instants);

Review comment:
       I'm shocked that this method does nothing before, the return value is ignored, please help to conform this @nsivabalan :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org