You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2016/04/07 20:21:17 UTC
[07/12] incubator-beam git commit: [BEAM-151] Remove references to
Dataflow runners
[BEAM-151] Remove references to Dataflow runners
This prevents moving DataflowPipelineRunner and subclasses to runner specific maven module.
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/49d65946
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/49d65946
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/49d65946
Branch: refs/heads/master
Commit: 49d65946e4b11afe50a926e9846c4e12b1529aa3
Parents: c8f09a0
Author: Luke Cwik <lc...@google.com>
Authored: Mon Mar 28 13:26:19 2016 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Thu Apr 7 11:19:49 2016 -0700
----------------------------------------------------------------------
.../dataflow/sdk/options/PipelineOptionsFactoryTest.java | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/49d65946/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/options/PipelineOptionsFactoryTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/options/PipelineOptionsFactoryTest.java b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/options/PipelineOptionsFactoryTest.java
index d9d62c8..d8ba8e3 100644
--- a/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/options/PipelineOptionsFactoryTest.java
+++ b/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/options/PipelineOptionsFactoryTest.java
@@ -29,8 +29,6 @@ import static org.junit.Assert.assertTrue;
import com.google.cloud.dataflow.sdk.Pipeline;
import com.google.cloud.dataflow.sdk.PipelineResult;
-import com.google.cloud.dataflow.sdk.runners.BlockingDataflowPipelineRunner;
-import com.google.cloud.dataflow.sdk.runners.DataflowPipelineRunner;
import com.google.cloud.dataflow.sdk.runners.DirectPipelineRunner;
import com.google.cloud.dataflow.sdk.runners.PipelineRunner;
import com.google.cloud.dataflow.sdk.testing.ExpectedLogs;
@@ -829,20 +827,21 @@ public class PipelineOptionsFactoryTest {
@Test
public void testSettingRunner() {
- String[] args = new String[] {"--runner=BlockingDataflowPipelineRunner"};
+ String[] args = new String[] {"--runner=DirectPipelineRunner"};
PipelineOptions options = PipelineOptionsFactory.fromArgs(args).create();
- assertEquals(BlockingDataflowPipelineRunner.class, options.getRunner());
+ assertEquals(DirectPipelineRunner.class, options.getRunner());
}
@Test
public void testSettingRunnerFullName() {
String[] args =
- new String[] {String.format("--runner=%s", DataflowPipelineRunner.class.getName())};
+ new String[] {String.format("--runner=%s", DirectPipelineRunner.class.getName())};
PipelineOptions opts = PipelineOptionsFactory.fromArgs(args).create();
- assertEquals(opts.getRunner(), DataflowPipelineRunner.class);
+ assertEquals(opts.getRunner(), DirectPipelineRunner.class);
}
+
@Test
public void testSettingUnknownRunner() {
String[] args = new String[] {"--runner=UnknownRunner"};