You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/30 04:35:00 UTC
Review Request 68565: Fixed SLRP compilation with Clang 3.5.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
Repository: mesos
Description
-------
Clang 3.5 incorrectly keeps const qualifiers when inferring the return
types of lambdas if their return expressions are const-qualified. This
patch makes the return types explicit to avoid this issue when compiling
SLRP.
Diffs
-----
src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
Diff: https://reviews.apache.org/r/68565/diff/1/
Testing
-------
make check with clang 3.5.
Thanks,
Chun-Hung Hsiao
Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/#review208121
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Aug. 30, 2018, 7:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68565/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 7:09 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-9193
> https://issues.apache.org/jira/browse/MESOS-9193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clang 3.5 incorrectly keeps const qualifiers when inferring the return
> types of lambdas if their return expressions are const-qualified. This
> patch makes the return types explicit to avoid this issue when compiling
> SLRP and its tests.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
> src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed
>
>
> Diff: https://reviews.apache.org/r/68565/diff/2/
>
>
> Testing
> -------
>
> make check with clang 3.5.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/#review211793
-----------------------------------------------------------
Ship it!
- Chun-Hung Hsiao
On Aug. 30, 2018, 5:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68565/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 5:09 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-9193
> https://issues.apache.org/jira/browse/MESOS-9193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clang 3.5 incorrectly keeps const qualifiers when inferring the return
> types of lambdas if their return expressions are const-qualified. This
> patch makes the return types explicit to avoid this issue when compiling
> SLRP and its tests.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
> src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed
>
>
> Diff: https://reviews.apache.org/r/68565/diff/2/
>
>
> Testing
> -------
>
> make check with clang 3.5.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/#review208119
-----------------------------------------------------------
PASS: Mesos patch 68565 was successfully built and tested.
Reviews applied: `['68564', '68565']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2262/mesos-review-68565
- Mesos Reviewbot Windows
On Aug. 29, 2018, 10:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68565/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 10:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-9193
> https://issues.apache.org/jira/browse/MESOS-9193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Clang 3.5 incorrectly keeps const qualifiers when inferring the return
> types of lambdas if their return expressions are const-qualified. This
> patch makes the return types explicit to avoid this issue when compiling
> SLRP and its tests.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
> src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed
>
>
> Diff: https://reviews.apache.org/r/68565/diff/2/
>
>
> Testing
> -------
>
> make check with clang 3.5.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/
-----------------------------------------------------------
(Updated Aug. 30, 2018, 5:09 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
Changes
-------
Fixed test compilation.
Bugs: MESOS-9193
https://issues.apache.org/jira/browse/MESOS-9193
Repository: mesos
Description (updated)
-------
Clang 3.5 incorrectly keeps const qualifiers when inferring the return
types of lambdas if their return expressions are const-qualified. This
patch makes the return types explicit to avoid this issue when compiling
SLRP and its tests.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed
Diff: https://reviews.apache.org/r/68565/diff/2/
Changes: https://reviews.apache.org/r/68565/diff/1-2/
Testing
-------
make check with clang 3.5.
Thanks,
Chun-Hung Hsiao