You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/20 10:50:16 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #5000: Allow overriding error type in DataFusion Result
tustvold opened a new pull request, #5000:
URL: https://github.com/apache/arrow-datafusion/pull/5000
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
This is technically a breaking change, as there are some rare cases where this will now result in a compile error as it cannot infer the return type.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #5000: Allow overriding error type in DataFusion Result
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #5000:
URL: https://github.com/apache/arrow-datafusion/pull/5000#discussion_r1082629158
##########
datafusion/common/src/error.rs:
##########
@@ -34,7 +34,7 @@ use parquet::errors::ParquetError;
use sqlparser::parser::ParserError;
/// Result type for operations that could result in an [DataFusionError]
-pub type Result<T> = result::Result<T, DataFusionError>;
+pub type Result<T, E = DataFusionError> = result::Result<T, E>;
Review Comment:
Cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5000: Allow overriding error type in DataFusion Result
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #5000:
URL: https://github.com/apache/arrow-datafusion/pull/5000#issuecomment-1398486195
Benchmark runs are scheduled for baseline = 65555d770ad0d747e9e87752888ddd3dd69d6765 and contender = 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2. 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c64f7dd7cbb04cbda1e80a036e23c806...56a8bcee1cd643ce80865ba3a710a119/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a9cc618429c5492c8721628c4c0defc5...5e2ba9d6ebf94d83bcc8944cc96a2cbf/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d9c4a6f8eca74884b8c384cbb0df4474...622391ae626e47fb978bce2975b24d3f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a8d2c8b8073441b28e96126e96f658b2...906ec70e752e49e0bc4258521395f2ec/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5000: Allow overriding error type in DataFusion Result
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #5000:
URL: https://github.com/apache/arrow-datafusion/pull/5000#discussion_r1082445576
##########
datafusion/common/src/error.rs:
##########
@@ -34,7 +34,7 @@ use parquet::errors::ParquetError;
use sqlparser::parser::ParserError;
/// Result type for operations that could result in an [DataFusionError]
-pub type Result<T> = result::Result<T, DataFusionError>;
+pub type Result<T, E = DataFusionError> = result::Result<T, E>;
Review Comment:
This is the actual change as I undertand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #5000: Allow overriding error type in DataFusion Result
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #5000:
URL: https://github.com/apache/arrow-datafusion/pull/5000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org