You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2023/08/31 13:40:52 UTC
[GitHub] [hbase-operator-tools] NihalJain opened a new pull request, #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
NihalJain opened a new pull request, #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache9 commented on a diff in pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#discussion_r1311681098
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -613,8 +613,7 @@ private static String getCommandUsage() {
private static void usageAddFsRegionsMissingInMeta(PrintWriter writer) {
writer.println(" " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES + " [OPTIONS]");
- writer.println(" [<NAMESPACE|"
- + "NAMESPACE:TABLENAME>...|-i <INPUTFILES>...]");
+ writer.println(" [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|-i <INPUTFILES>...]");
Review Comment:
Here we could just remove the '+' operator?
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -800,8 +798,8 @@ private static void usageExtraRegionsInMeta(PrintWriter writer) {
}
private static void usageReportMissingRegionsInMeta(PrintWriter writer) {
- writer.println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|"
- + "NAMESPACE:TABLENAME>...|");
+ writer
+ .println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|");
Review Comment:
Ditto. At least we could remove the last '+'.
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -767,8 +766,7 @@ private static void usageReplication(PrintWriter writer) {
}
private static void usageExtraRegionsInMeta(PrintWriter writer) {
- writer.println(" " + EXTRA_REGIONS_IN_META + " [<NAMESPACE|"
- + "NAMESPACE:TABLENAME>...|");
+ writer.println(" " + EXTRA_REGIONS_IN_META + " [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|");
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#issuecomment-1701181602
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 49s | master passed |
| +1 :green_heart: | compile | 0m 10s | master passed |
| +1 :green_heart: | checkstyle | 0m 7s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 10s | the patch passed |
| +1 :green_heart: | compile | 0m 9s | the patch passed |
| +1 :green_heart: | javac | 0m 9s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 5s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 38s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/137 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 8b12821a9e0d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 0bf6ee1 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/testReport/ |
| Max. process+thread count | 1282 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#issuecomment-1701088323
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 9s | master passed |
| +1 :green_heart: | checkstyle | 0m 8s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 4s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 5s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 36s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/137 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 8da7bcc01db7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 0bf6ee1 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/testReport/ |
| Max. process+thread count | 1257 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on a diff in pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#discussion_r1311688243
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -800,8 +798,8 @@ private static void usageExtraRegionsInMeta(PrintWriter writer) {
}
private static void usageReportMissingRegionsInMeta(PrintWriter writer) {
- writer.println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|"
- + "NAMESPACE:TABLENAME>...|");
+ writer
+ .println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|");
Review Comment:
Right. Let me fix these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#issuecomment-1701300613
Thank you @petersomogyi and @Apache9 for the reviews. Merged the changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137#issuecomment-1701147227
Updated PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain merged pull request #137: HBASE-28057 Run spotless:apply and fix any existing spotless issues
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #137:
URL: https://github.com/apache/hbase-operator-tools/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org