You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/02 16:31:46 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4285: Add debug logs to smoosh test
nickva opened a new pull request, #4285:
URL: https://github.com/apache/couchdb/pull/4285
Saw this fail 2 in a the last week or so but couldn't reproduce it locally. Instead of deleting, this is an attempt to emit debug lines to see how far it goes before it times out in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4285: Add debug logs to smoosh test
Posted by GitBox <gi...@apache.org>.
nickva commented on PR #4285:
URL: https://github.com/apache/couchdb/pull/4285#issuecomment-1335508950
The output with the debug lines should look like:
```
smoosh_tests:27: smoosh_test_ (t_checkpointing_works)...test/smoosh_tests.erl:242:<0.1658.0>: <-
test/smoosh_tests.erl:249:<0.1658.0>: <-
test/smoosh_tests.erl:251:<0.1658.0>: <-
test/smoosh_tests.erl:252:<0.1658.0>: <-
test/smoosh_tests.erl:260:<0.1658.0>: <-
test/smoosh_tests.erl:262:<0.1658.0>: <-
test/smoosh_tests.erl:265:<0.1658.0>: <-
test/smoosh_tests.erl:267:<0.1658.0>: <-
[0.312 s] ok
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4285: Add debug logs to smoosh test
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4285:
URL: https://github.com/apache/couchdb/pull/4285#discussion_r1038334171
##########
src/smoosh/test/smoosh_tests.erl:
##########
@@ -239,24 +239,33 @@ t_checkpointing_works(DbName) ->
setup_db_compactor_intercept(),
{ok, _} = delete_doc(DbName, <<"doc1">>),
ok = wait_to_enqueue(DbName),
+ ?debugHere,
CompPid = wait_db_compactor_pid(),
ChanPid = get_channel_pid("ratio_dbs"),
config:set("smoosh", "persist", "true", false),
meck:reset(smoosh_channel),
ChanPid ! checkpoint,
% Wait for checkpoint process to exit
+ ?debugHere,
ok = wait_normal_down(),
+ ?debugHere,
+ ?debugHere,
Review Comment:
Doh, that's a silly copy-paste error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4285: Add debug logs to smoosh test
Posted by GitBox <gi...@apache.org>.
jaydoane commented on code in PR #4285:
URL: https://github.com/apache/couchdb/pull/4285#discussion_r1038332868
##########
src/smoosh/test/smoosh_tests.erl:
##########
@@ -239,24 +239,33 @@ t_checkpointing_works(DbName) ->
setup_db_compactor_intercept(),
{ok, _} = delete_doc(DbName, <<"doc1">>),
ok = wait_to_enqueue(DbName),
+ ?debugHere,
CompPid = wait_db_compactor_pid(),
ChanPid = get_channel_pid("ratio_dbs"),
config:set("smoosh", "persist", "true", false),
meck:reset(smoosh_channel),
ChanPid ! checkpoint,
% Wait for checkpoint process to exit
+ ?debugHere,
ok = wait_normal_down(),
+ ?debugHere,
+ ?debugHere,
Review Comment:
what is the goal of having two consecutive debug statements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4285: Add debug logs to smoosh test
Posted by GitBox <gi...@apache.org>.
nickva merged PR #4285:
URL: https://github.com/apache/couchdb/pull/4285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org