You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2013/10/04 10:02:34 UTC
Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Oct. 25, 2013, 11:05 p.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, line 137
> > <https://reviews.apache.org/r/14486/diff/3/?file=362023#file362023line137>
> >
> > This should change to "Error compiling query"
> >
Done
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review27504
-----------------------------------------------------------
On Oct. 7, 2013, 6:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 6:51 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review27504
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
<https://reviews.apache.org/r/14486/#comment53428>
This should change to "Error compiling query"
- Thejas Nair
On Oct. 7, 2013, 6:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 6:51 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Brock Noland <br...@cloudera.com>.
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > OK, I see what you mean. I was looking at just the commented line, and didn't look at the full view-diff page. Yes, the releaseLocks won't get called. That looks like a problem.
> >
> > Thanks to Vaibhav to pointing it out to me.
>
> Brock Noland wrote:
> OK, thanks for responding. I'll open a jira.
https://issues.apache.org/jira/browse/HIVE-5781
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28467
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Brock Noland <br...@cloudera.com>.
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > OK, I see what you mean. I was looking at just the commented line, and didn't look at the full view-diff page. Yes, the releaseLocks won't get called. That looks like a problem.
> >
> > Thanks to Vaibhav to pointing it out to me.
OK, thanks for responding. I'll open a jira.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28467
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > OK, I see what you mean. I was looking at just the commented line, and didn't look at the full view-diff page. Yes, the releaseLocks won't get called. That looks like a problem.
> >
> > Thanks to Vaibhav to pointing it out to me.
>
> Brock Noland wrote:
> OK, thanks for responding. I'll open a jira.
>
> Brock Noland wrote:
> https://issues.apache.org/jira/browse/HIVE-5781
I guess the lock are acquired a bit later, just before the execution. We can actually get rid of that releaseLocks() in case of compiler error.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28467
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28467
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/14486/#comment55282>
OK, I see what you mean. I was looking at just the commented line, and didn't look at the full view-diff page. Yes, the releaseLocks won't get called. That looks like a problem.
Thanks to Vaibhav to pointing it out to me.
- Thejas Nair
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28448
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Brock Noland <br...@cloudera.com>.
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > Question: what happens if compile throws an exception, like NPE or something. Does that mean the locks do not get released?
> >
> > If that is true then I think we should follow a follow-on jira, as it's not introduced here, to ensure the locks are released.
>
> Thejas Nair wrote:
> The lock will be freed if an exception is thrown. That is not a problem.
>
Great to hear! For my own learning purposes, could you share how exactly that will occur? I just don't see it.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Thejas Nair <th...@hortonworks.com>.
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > Question: what happens if compile throws an exception, like NPE or something. Does that mean the locks do not get released?
> >
> > If that is true then I think we should follow a follow-on jira, as it's not introduced here, to ensure the locks are released.
>
> Thejas Nair wrote:
> The lock will be freed if an exception is thrown. That is not a problem.
>
>
> Brock Noland wrote:
> Great to hear! For my own learning purposes, could you share how exactly that will occur? I just don't see it.
Using
sychronized(obj){
//sync code
}
is equivalent to -
obj.intrinsicLock.lock();
try{
//sync code
}
finally{
//gets called even on exception
obj.intrinsicLock.unlock();
}
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Brock Noland <br...@cloudera.com>.
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > Question: what happens if compile throws an exception, like NPE or something. Does that mean the locks do not get released?
> >
> > If that is true then I think we should follow a follow-on jira, as it's not introduced here, to ensure the locks are released.
>
> Thejas Nair wrote:
> The lock will be freed if an exception is thrown. That is not a problem.
>
>
> Brock Noland wrote:
> Great to hear! For my own learning purposes, could you share how exactly that will occur? I just don't see it.
>
> Thejas Nair wrote:
> Using
> sychronized(obj){
> //sync code
> }
> is equivalent to -
>
> obj.intrinsicLock.lock();
> try{
> //sync code
> }
> finally{
> //gets called even on exception
> obj.intrinsicLock.unlock();
> }
I think there maybe some kind of confusion here. I wasn't referring to the synchronized statement... I was referring to the HiveLock objects that the driver owns.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Thejas Nair <th...@hortonworks.com>.
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979
> > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979>
> >
> > Question: what happens if compile throws an exception, like NPE or something. Does that mean the locks do not get released?
> >
> > If that is true then I think we should follow a follow-on jira, as it's not introduced here, to ensure the locks are released.
The lock will be freed if an exception is thrown. That is not a problem.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28376
-----------------------------------------------------------
+1 from my side though we should wait to see if Carl or Thejas have anymore feedback.
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/14486/#comment55195>
Question: what happens if compile throws an exception, like NPE or something. Does that mean the locks do not get released?
If that is true then I think we should follow a follow-on jira, as it's not introduced here, to ensure the locks are released.
- Brock Noland
On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:50 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 11:50 p.m.)
Review request for hive.
Changes
-------
Rebased and addressed the review feedback.
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Oct. 25, 2013, 7 p.m., Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 962
> > <https://reviews.apache.org/r/14486/diff/3/?file=362022#file362022line962>
> >
> > Please remove.
Done
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review27543
-----------------------------------------------------------
On Oct. 7, 2013, 6:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 6:51 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review27543
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/14486/#comment53461>
Please remove.
- Carl Steinbach
On Oct. 7, 2013, 6:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 6:51 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5441
> https://issues.apache.org/jira/browse/HIVE-5441
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Separate out the query compilation and execute that part synchronously.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
>
> Diff: https://reviews.apache.org/r/14486/diff/
>
>
> Testing
> -------
>
> Added test cases
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 6:51 p.m.)
Review request for hive.
Changes
-------
Updated dependency on 14484 (HIVE-5440)
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 6:50 p.m.)
Review request for hive.
Changes
-------
Updated patch
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
(Updated Oct. 4, 2013, 8:19 a.m.)
Review request for hive.
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar
Re: Review Request 14486: HIVE-5441: Async query execution doesn't return
resultset status
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/
-----------------------------------------------------------
(Updated Oct. 4, 2013, 8:18 a.m.)
Review request for hive.
Changes
-------
Test update
Bugs: HIVE-5441
https://issues.apache.org/jira/browse/HIVE-5441
Repository: hive-git
Description
-------
Separate out the query compilation and execute that part synchronously.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5308e2c
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8
Diff: https://reviews.apache.org/r/14486/diff/
Testing
-------
Added test cases
Thanks,
Prasad Mujumdar