You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/05/15 22:04:11 UTC
Review Request 59299: GEODE-2874: Fix StringIndexOutOfBoundsException
while initializing logger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/
-----------------------------------------------------------
Review request for geode.
Repository: geode
Description
-------
GEODE-2874: Fix StringIndexOutOfBoundsException while initializing logger
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java f814aebb8717c3a53c72d4cdf55b81d72e0fbed5
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java 5ea77c4119b7551d0f2fd8283f5ce6108b3295a1
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java b86e058960e42e4d276f8fd66c26bb3fc4d3d876
Diff: https://reviews.apache.org/r/59299/diff/1/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 59299: GEODE-2874: Fix
StringIndexOutOfBoundsException while initializing logger
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/#review175041
-----------------------------------------------------------
Ship it!
Ship It!
- Ken Howe
On May 15, 2017, 10:31 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59299/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:31 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2874: Fix StringIndexOutOfBoundsException while initializing logger
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java f814aeb
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java 5ea77c4
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java b86e058
>
>
> Diff: https://reviews.apache.org/r/59299/diff/2/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 59299: GEODE-2874: Fix
StringIndexOutOfBoundsException while initializing logger
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/#review175160
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 15, 2017, 10:31 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59299/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:31 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2874: Fix StringIndexOutOfBoundsException while initializing logger
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java f814aeb
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java 5ea77c4
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java b86e058
>
>
> Diff: https://reviews.apache.org/r/59299/diff/2/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 59299: GEODE-2874: Fix
StringIndexOutOfBoundsException while initializing logger
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/
-----------------------------------------------------------
(Updated May 15, 2017, 10:31 p.m.)
Review request for geode.
Repository: geode
Description
-------
GEODE-2874: Fix StringIndexOutOfBoundsException while initializing logger
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java f814aeb
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java 5ea77c4
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java b86e058
Diff: https://reviews.apache.org/r/59299/diff/2/
Changes: https://reviews.apache.org/r/59299/diff/1-2/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 59299: GEODE-2874: Fix
StringIndexOutOfBoundsException while initializing logger
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59299/#review175036
-----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java
Lines 1 (patched)
<https://reviews.apache.org/r/59299/#comment248353>
Formatting of the license note
geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java
Lines 42 (patched)
<https://reviews.apache.org/r/59299/#comment248354>
I'd favor a more descriptive test name that won't prompt digging through a JIRA to figure out what the intent is. "testGeode2874_nameWithoutExtensionDoesntThrow"?
- Ken Howe
On May 15, 2017, 10:04 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59299/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:04 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2874: Fix StringIndexOutOfBoundsException while initializing logger
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java f814aebb8717c3a53c72d4cdf55b81d72e0fbed5
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerDUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandlerIntegrationTest.java 5ea77c4119b7551d0f2fd8283f5ce6108b3295a1
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java b86e058960e42e4d276f8fd66c26bb3fc4d3d876
>
>
> Diff: https://reviews.apache.org/r/59299/diff/1/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>