You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by echarles <gi...@git.apache.org> on 2017/04/05 15:43:24 UTC
[GitHub] zeppelin pull request #2226: [ZEPPELIN-2235] Helium load.js should reside in...
GitHub user echarles opened a pull request:
https://github.com/apache/zeppelin/pull/2226
[ZEPPELIN-2235] Helium load.js should reside in subfolder + update babel and webpack versions
### What is this PR for?
Changes are needed to make zeppelin-sigma-spell work.
The solution that worked for me was to update HeliumBundleFactory.java and webpack.config.js so the load.js now resided in a subfolder (local-repo/helium-bundle/src/).
The positive side-effect for me is also that the generation of the webpack is faster (maybe because the node_modules are not more scanned?).
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2235
### How should this be tested?
Start and enable the zeppelin-sigma-spell
Test in a paragraph with
```
%sigma
{
"nodes":[
{"label":"n-1","x":-100,"y":"0","id":"1","attributes":{},"color":"red","size":10},
{"label":"n-2","x":0,"y":0,"id":"2","attributes":{},"color":"yellow","size":10},
{"label":"n-3","x":0,"y":-100,"id":"3","attributes":{},"color":"green","size":10.0},
{"label":"n-4","x":-100,"y":-100,"id":"4","attributes":{},"color":"green","size":10.0}
],
"edges":[
{"source":"1","target":"2","id":"1-2","color":"red","size":10.0},
{"source":"1","target":"3","id":"1-3","color":"green","size":10.0},
{"source":"4","target":"3","id":"4-1","color":"green","size":10.0}
]
}
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/datalayer/zeppelin ZEPPELIN-2235
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2226
----
commit ebe7ebb336f182581df5e2c5d7df01308f88b367
Author: Eric Charles <er...@datalayer.io>
Date: 2017-03-18T11:23:13Z
Automatic message for commit of samedi 18 mars 2017, 11:23:13 (UTC+0000)
commit 39543dec69555ec9968175ad6f8a36dcb7a28ae0
Author: Eric Charles <er...@datalayer.io>
Date: 2017-03-25T13:03:02Z
Merge branch 'master' of https://github.com/apache/zeppelin
commit e89fd7098c11a821bbb78498f627eada0700992d
Author: Eric Charles <er...@datalayer.io>
Date: 2017-03-29T04:00:14Z
Merge branch 'master' of https://github.com/apache/zeppelin
commit 2fb48c0a8db6e5bd154861133724e0d0947bf792
Author: Eric Charles <er...@datalayer.io>
Date: 2017-04-05T13:16:40Z
Merge branch 'master' of https://github.com/apache/zeppelin
commit 38fe62869bf98ec6c77934c03befb0924ffa58bf
Author: Eric Charles <er...@datalayer.io>
Date: 2017-04-05T15:34:46Z
more load js in subfolder and update package.json + webpack.config.js to ensure zeppelin-sigma-spell works fine
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2226: [ZEPPELIN-2235] Helium load.js should reside in...
Posted by echarles <gi...@git.apache.org>.
Github user echarles closed the pull request at:
https://github.com/apache/zeppelin/pull/2226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2226: [ZEPPELIN-2235] Helium load.js should reside in subfol...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/2226
This is solved with #2210 Bundle helium packages one by one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---