You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by rickysaltzer <gi...@git.apache.org> on 2015/08/27 22:20:38 UTC
[GitHub] nifi pull request: NIFI-604: Custom Argument Delimiters ExecuteStr...
GitHub user rickysaltzer opened a pull request:
https://github.com/apache/nifi/pull/78
NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess
- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments. This enables
the ExecuteStreamCommand to use semicolons as part of arguments.
- Argument delimiters can now be specified. Their default being what they were using before (ExecuteStreamCommand -> ';' , ExecuteProcess -> ' ')
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rickysaltzer/nifi NIFI-604
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 9cefc4a5a54adf63bf4eb67c4b8211f2a2b5dd14
Author: ricky <ri...@cloudera.com>
Date: 2015-08-27T19:02:37Z
NIFI-604: Custom Argument Delimiters ExecuteStreamCommand / ExecuteProcess
- Unified the way ExecuteStreamCommand and ExecuteProcess handle arguments
- Argument delimiters can now be specified. Their default being what they were using before (; and space)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-604: Custom Argument Delimiters ExecuteStr...
Posted by rickysaltzer <gi...@git.apache.org>.
Github user rickysaltzer commented on the pull request:
https://github.com/apache/nifi/pull/78#issuecomment-135543956
There's one thing I would like to call attention to. Users of the StreamCommand who were using \n \r or \t characters outside of quotes might have unexpected results since the ExecuteProcess command used those as delimiters in addition to the space delimiter. It's doubtful that a lot of people were doing this, but it's something to consider.
One option is to have a "Use Default Delimiters" checkbox that's enabled by default on the ExecuteProcess and disabled by default on the ExecuteStreamCommand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-604: Custom Argument Delimiters ExecuteStr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---