[GitHub] [couchdb] nickva commented on a change in pull request #2649: couch_jobs resubmit updates job data

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #2649: couch_jobs resubmit updates job data
URL: https://github.com/apache/couchdb/pull/2649#discussion_r390355349
 
 

 ##########
 File path: src/couch_jobs/src/couch_jobs_fdb.erl
 ##########
 @@ -205,8 +206,11 @@ finish(#{jtx := true} = JTx0, #{jlock := <<_/binary>>} = Job, Data) when
             {error, halt}
     end.
 
+resubmit(JTx0, Job, NewSTime) ->
 
 Review comment:
   Let's switch it such that the new `Data` parameter is at the end of the parameter list.
   
   So the resubmit version look like:
   
   ```
   resubmit(Tx, Job, SchedTime).
   resubmit(Tx, Job, SchedTime, Data)
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services