You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/02/15 08:27:45 UTC
[kudu-CR] [Tool] Show the information of a tablet
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19501
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the table id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
8 files changed, 110 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/1
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#8).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 293 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/8
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 8
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#24).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
ID | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+--------------------+------+-------+----
abc | test_table | xxxxx | host1| 43689 | V
abd | test_table | xxxx1 | host2| 43035 | L
dbe | test_table | xxxx2 | host3| 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 135 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/24
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#15).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_tablet.cc
9 files changed, 180 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/15
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> This commit is done as you advised. I maybe miss something. Could you give
I am thinking the implement scheme of this patch again.
rpc GetTabletLocations(GetTabletLocationsRequestPB) returns (GetTabletLocationsResponsePB)
You can use this rpc in Kudu CLI to implements this patch. The information of tablet name is not
in GetTabletLocationsResponsePB, so the message structure GetTabletLocationsResponsePB can add this field, like this:
message GetTabletLocationsResponsePB {
optional MasterErrorPB error = 1;
repeated TabletLocationsPB tablet_locations = 2;
// Used if 'intern_ts_infos_in_response' was requested.
// See InternedReplicaPB above.
repeated TSInfoPB ts_infos = 4;
message Error {
required bytes tablet_id = 1;
required AppStatusPB status = 2;
}
repeated Error errors = 3;
// add two fields at this.
optional string table_id = 5;
optional string table_name = 6;
}
All information of your output is included can extract from this response.
It's not necessary to change client's codes, as some people said, public some information about tablet is not good.
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503
PS12, Line 503: table_info_in_response
> table_info is stored in TabletLocationsPB of GetTabletLocationsResponsePB.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 13
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:23:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19501/4/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/4/src/kudu/master/master.proto@459
PS4, Line 459: filed
nit: field
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@321
PS3, Line 321: cerr << "Replaced tablet " << tablet_id << " with tablet ";
> Done
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: ilable.\n
> Done
seems no changes about this?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 03:21:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#7).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The follow is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 293 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/7
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h@802
PS11, Line 802:
Remove one blank line.
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: message TableInfoPB {
Of course it's convenient to obtain table info by sending GetTabletLocations request, however, there is a 'table info' in ListTablesResponsePB, why not reuse it? If some day we want some more 'table info' by GetTabletLocations request, will add more fields in TabletLocationsPB.TableInfoPB?
Is reuse ListTablesResponsePB, the new CLI tool is compatiable to old server too.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 31 Mar 2023 09:12:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 9:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@298
PS9, Line 298: Status KuduClient::Data::GetTablet(KuduClient* client,
> I'm not clear why to move this function from KuduClient to KuduClient::Data
Just to keep the same style. Client.cc exposes the interface to the user, and client-internal.cc implements the interface. Please see the following function: GetTabletServer()
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@301
PS9, Line 301: const
> At least, it can be static (in L307, use client->default_admin_operation_ti
Done L307.
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h@797
PS9, Line 797: get_extra_info
> Could you plz add some comments to describe what dose 'get_extra_info' mean
Done
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc@6241
PS9, Line 6241: R
> nit: indent
Done
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@109
PS9, Line 109: if (FLAGS_json) {
> DataTable is support to output in JSON format(see DataTable::PrintTo), why
Done
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@124
PS9, Line 124: cout << Substitute("Table id: $0, Table name: $1",
> So if --json is enabled, table id and name will not be output?
To simply the code, I will output table id and table name for every replica. Maybe the data has some duplication, but it does matter. The following is an example:
pretty format:
Table Id | Table Name | Tablet Server UUID | Host | Port | Is Leader
----------------------------------+------------+----------------------------------+---------------+-------+-----------
883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 5116514e00024a71926c722f5ccfaf44 | 127.42.53.193 | 41263 | false
883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 7041740e966d45d38be3cc6c79c1f67f | 127.42.53.194 | 35579 | true
883e5ffc9e2f41f780ddffd8a8744f13 | test_table | 4c4d43e7e0bc4d41b23f072ad2dfe85d | 127.42.53.195 | 40701 | false
json format:
[{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"909a581760ae40ceb8837d72cc989ede","Host":"127.45.86.65","Port":"44353","Is Leader":"true"},{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"b509cc1057af4dda9cc596c7f87849a1","Host":"127.45.86.66","Port":"42719","Is Leader":"false"},{"Table Id":"53092288a6944385bcb78fdc6a2d5322","Table Name":"test_table","Tablet Server UUID":"9413e042a42549409367c722a50785e4","Host":"127.45.86.67","Port":"36483","Is Leader":"false"}]
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Mar 2023 12:04:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h@1180
PS2, Line 1180: const std::string& table_id() const;
: const std::string& table_name() const;
> Expose functions to user client should be very carefully, we have to mainte
KuduTablet::Data is private to CLI tools. Friendly class seems to be no suitable also.
A similar data structure: TabletInfo defined in catalog_manager.h also contains the information of table. KuduTablet contains table_id, table_name may be ok.
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto@449
PS2, Line 449: optional string table_name = 9;
> If we want to use the feature we have to upgrade the servers, can we gather
Currently no suitable functions found to get the table info according tablet id.
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@300
PS2, Line 300: for (const auto& replica : tablet->replicas()) {
: TabletInfoPB::LocationIn
> nit: return cmatrix.PrintTo(cout); ?
The out parameter of PrintTo() is ostream
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 24 Feb 2023 06:42:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 12:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> I review this patch again.
This commit is done as you advised. I maybe miss something. Could you give more explain in detail?
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@17
PS12, Line 17: This tool will be helpful for debuging. The following is an
: exmple:
:
: Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
: Tablet Server UUID | Host | Port | Is Leader
: ----------------------------------+-----------------+-------+-----------
: 4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
: 65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
: 6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
> How about add examples of command lines?This will give us a more direct und
Done
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h@802
PS11, Line 802: // Replace the given tablet with a new, empty one. The replaced tablet is
> Done
Done
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8;
> I meant if reuse ListTablesRequestPB to collect table info (not add an extr
Do you mean the client send 2 RPCs to get related information? GetTabletLocationsRequestPB RPC gets tablet location information, and ListTablesRequestPB RPC gets the table information?
But we don't know the table name when finished GetTabletLocationsRequestPB RPC. How to send ListTablesRequestPB RPC.
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503
PS12, Line 503: table_info_in_response
> It seems 'GetTabletLocationsResponsePB' has no such field to save 'table_in
table_info is stored in TabletLocationsPB of GetTabletLocationsResponsePB. Please see line 459.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 14:32:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 5:
(7 comments)
Almost there: just few more items to address.
Thank you for working on this!
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto@460
PS5, Line 460: intern_ts_infos_in_response
I guess this field rather belongs to GetTabletLocationsRequestPB?
Also, consider naming this just 'table_info_in_response'.
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto@461
PS5, Line 461: optional bytes table_id = 9;
: optional string table_name = 10;
It would be great to create a dedicated message for this and add it just as a single field 'table_info' into this TabletLocationsPB.
E.g.:
message TabletLocationsPB {
...
message TableInfoPB {
optional bytes id = 1;
optional string name = 2;
}
...
optional TableInfoPB table_info = 8;
...
}
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: ilable.\n
> seems no changes about this?
+1
It seems the corresponding update is missing: it's still names 'show_info' in PS5. Consider updating to 'describe' or 'info', as suggested.
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@101
PS5, Line 101: TabletShower
This is C++, not Java, so I don't understand why to introduce otherwise useless class just to have a function or method.
C++ allows to declare a friend function as well, see https://en.cppreference.com/w/cpp/language/friend for the details. It can be even a template one: for an example, take a look at https://github.com/apache/kudu/blob/8ee73765fb78c246d3455029cdf02e15eac28926/src/kudu/util/once.h#L105-L106
BTW, 'TabletShower' is a bit funny if looking at it without much context, see https://en.wikipedia.org/wiki/Shower :)
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@126
PS5, Line 126: ostream out(std::cout.rdbuf());
Why would you need this? std::cout is std::ostream as well, so it fits where std::ostream is needed.
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@127
PS5, Line 127: out
Would it be enough using 'cout' here?
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@136
PS5, Line 136:
nit: wrong indent?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 06:56:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#6).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 290 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/6
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#22).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
ID | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+-------+-------+-------+----
abc | test_table | xxxxx | host1 | 43689 | V
abd | test_table | xxxx1 | host2 | 43035 | L
dbe | test_table | xxxx2 | host3 | 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 134 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/22
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 22
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417
PS18, Line 417: .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc })
> Current solution will output empty if a tablet id is not existed. If this C
Maybe adding a column for 'tablet id' in the table can resolve it.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 19
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 03:17:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG@13
PS3, Line 13: table id
tablet id?
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h
File src/kudu/client/tablet-internal.h:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h@31
PS3, Line 31: Data
> The variables' initialize order in construct function show be same as the o
+1
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.cc
File src/kudu/client/tablet-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.cc@37
PS3, Line 37: KuduTablet::Data::Data(string id, vector<const KuduReplica*> replicas,
: string table_id, string table_name)
: : id_(std::move(id)),
: replicas_(std::move(replicas)),
: table_id_(std::move(table_id)),
: table_name_(std::move(table_name))
The initialization order should correspond to the declaration order.
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448
PS3, Line 448: optional bytes table_id = 8
Why do we need to assign values from 8?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 12:28:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#14).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_tablet.cc
10 files changed, 181 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/14
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 14
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 9:
(4 comments)
> Patch Set 8:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG@17
PS7, Line 17: follow
> following
Done
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc@6276
PS7, Line 6276:
> nit: you could use std::move() here to prevent copying:
Done
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@126
PS7, Line 126: Tabl
> nit: Tablet Server UUID
Done
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@414
PS7, Line 414: Show information on the table which the tablet is a
> nit: maybe change this to be more specific
Done. Thanks for your comments.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Mar 2023 03:19:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h@802
PS11, Line 802: // Replace the given tablet with a new, empty one. The replaced tablet is
> Remove one blank line.
Done
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8;
> typo: If reusing ListTablesResponsePB, the new CLI tool is compatiable with
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 02 Apr 2023 08:35:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#17).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 130 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/17
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 17
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#23).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
ID | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+-------+-------+-------+----
abc | test_table | xxxxx | host1 | 43689 | V
abd | test_table | xxxx1 | host2 | 43035 | L
dbe | test_table | xxxx2 | host3 | 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 135 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/23
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 23
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#18).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 130 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/18
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 18
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/5//COMMIT_MSG@9
PS5, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
Could give s sample output?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 07:37:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 22:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG@22
PS20, Line 22: ID | Table Name | Tablet Server UUID | Host | Port | Is Leader
: -----+------------+-------+-------+-------+----
: abc | test_table | xxxxx | host1 | 43689 | V
: abd | test_table | xxxx1 | host2 | 43035 | L
: dbe | test_table | xxxx2 | host3 | 35209 | V
> nit: make the table columns are aligned.
Done
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4228
PS20, Line 4228: tablet_ids_st
> nit: tablet_ids_str ?
Done
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4252
PS20, Line 4252: R"("ID":"$0","Table Name":"$1","Tablet Server UUID":"$2","Host":"$3","Port":"$4")",
: tablets[j].tablet_status().tablet_id(),
> How about use "string literal" to improve readability? Refer to L1027
Done
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc@107
PS20, Line 107: ID
> nit: Tablet ID ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 22
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 18 Jun 2023 01:52:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#2).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the table id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
8 files changed, 110 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/2
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/4/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/4/src/kudu/master/master.proto@459
PS4, Line 459: field
> nit: field
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 11:05:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@101
PS5, Line 101: TabletShower
> One of the advantages of using frined class v.s friend function is the clas
IMO, creating nonsensical classes to justify some 'too long signature' is a much worse code smell.
Maybe, we should then switch to just enumerating all the method names, naming them to be f_001(), ..., f_100(), etc. to shorten their signatures? The same for the names of types, parameters, and variables. Or, an even brighter idea would be creating a miriad of classes, each with a single method named DoIt(). Would you consider that to be a better code, Yingchun Lai? :)
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Mar 2023 20:47:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#12).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 273 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/12
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8;
> Done
I meant if reuse ListTablesRequestPB to collect table info (not add an extra optional field 'table_info_in_response' in GetTabletLocationsRequestPB), the goal can be achieved and it's compatiable with the old version of servers (not needed to update the server side code). Right?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 15:27:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 18:
(4 comments)
> Patch Set 15:
>
> (1 comment)
one
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name and all replicas on
: different tablet servers according to the tablet id.
:
> I think both solutions can unified as one.
Thanks every one. I decide to adopt the first advice. Get all tablets information and filter the one which matches the tablet id.
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h@103
PS15, Line 103: internal::RemoteTabletServer** ts);
> This change is not matter with this patch, so you can fix it at another pat
Done
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc@293
PS15, Line 293: {
> This change is not matter with this patch, so you can fix it at another pat
Done
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto@459
PS15, Line 459: // DEPRECATED. Still set by servers, but should be igno
> move this line to the end? and writing some comments is better.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 18
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 04 Jun 2023 01:44:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 7: Code-Review+1
(4 comments)
Overall looks good, just a few nits
http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/7//COMMIT_MSG@17
PS7, Line 17: follow
following
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/master/catalog_manager.cc@6276
PS7, Line 6276: locs_pb->mutable_table_info()->CopyFrom(table_info_pb);
nit: you could use std::move() here to prevent copying:
*locs_pb->mutable_table_info() = std::move(table_info_pb);
Alternatively, it could be:
auto* info = locs_pb->mutable_table_info();
info->set_id(tablet_info->table()->id());
info->set_name(tablet_info->table()->table_name());
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@126
PS7, Line 126: UUID
nit: Tablet Server UUID
http://gerrit.cloudera.org:8080/#/c/19501/7/src/kudu/tools/tool_action_tablet.cc@414
PS7, Line 414: Show the table and location information of a tablet.
nit: maybe change this to be more specific
Show information on the table which the tablet is a part of and where tablet replicas are located.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 19 Mar 2023 17:42:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 20: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/20//COMMIT_MSG@22
PS20, Line 22: id | Table Name | Tablet Server UUID | Host | Port | Is Leader
: -----+------------+-------+-------+-------+----
: abc | test_table | xxxxx | host1 | 43689 | V
: abd | test_table | xxxx1 | host2 | 43035 | L
: dbe | test_table | xxxx2 | host3 | 35209 | V
nit: make the table columns are aligned.
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4228
PS20, Line 4228: table_ids_str
nit: tablet_ids_str ?
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/kudu-tool-test.cc@4252
PS20, Line 4252: "\"id\":\"$0\",\"Table Name\":\"$1\","
: "\"Tablet Server UUID\":\"$2\",\"Host\":\"$3\",\"Port\":\"$4\""
How about use "string literal" to improve readability? Refer to L1027
See more details: https://en.cppreference.com/w/cpp/language/string_literal
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/20/src/kudu/tools/tool_action_tablet.cc@107
PS20, Line 107: id
nit: Tablet ID ?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 20
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Jun 2023 16:51:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 24: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 24
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 18 Jun 2023 05:28:51 +0000
Gerrit-HasComments: No
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#21).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
id | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+-------+-------+-------+----
abc | test_table | xxxxx | host1 | 43689 | V
abd | test_table | xxxx1 | host2 | 43035 | L
dbe | test_table | xxxx2 | host3 | 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 134 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/21
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 21
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> I am thinking the implement scheme of this patch again.
Thank you. I think your solution is better. I will adopt your advice. Please review again.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 12:30:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#19).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table Name | Tablet Server UUID | Host | Port | Is Leader
------------+--------------------+-------------+-------+----
test_table | xxxxx | host1 | 43689 | V
test_table | xxxx1 | host2 | 43035 | L
test_table | xxxx2 | host3 | 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 121 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/19
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 19
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
I review this patch again.
I find GetTabletLocationsRequestPB and GetTabletLocationsResponsePB can get most of the information.
The missing infomation is table name. So I think we can add this information field about table in GetTabletLocationsResponsePB.
At CLI command side, send GetTabletLocations request like what some other command does, we can avoid changing kudu cpp client and avoid publishing some messages we don't want to publish.
What do you think?
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503
PS12, Line 503: table_info_in_response
It seems 'GetTabletLocationsResponsePB' has no such field to save 'table_info', how to use table_info_in_response?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 11:23:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@17
PS12, Line 17: This tool will be helpful for debuging. The following is an
: exmple:
:
: Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
: Tablet Server UUID | Host | Port | Is Leader
: ----------------------------------+-----------------+-------+-----------
: 4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
: 65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
: 6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
How about add examples of command lines?This will give us a more direct understanding of the usage method.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 12
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 12:13:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8;
> Do you mean the client send 2 RPCs to get related information? GetTabletLoc
Yes, but use KuduClient::Data::ListTablesWithInfo() and KuduScanTokenBuilder to get tokens on a table, similar to TableLister::ListTablets in src/kudu/tools/tool_action_table.cc.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 13
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 09 Apr 2023 16:12:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 9:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@298
PS9, Line 298: Status KuduClient::Data::GetTablet(KuduClient* client,
I'm not clear why to move this function from KuduClient to KuduClient::Data, it's possible to hide this function in private scope of KuduClient, right?
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/client/client-internal.cc@301
PS9, Line 301: const
At least, it can be static (in L307, use client->default_admin_operation_timeout() instead of default_admin_operation_timeout_)
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.h@797
PS9, Line 797: get_extra_info
Could you plz add some comments to describe what dose 'get_extra_info' mean?
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/master/catalog_manager.cc@6241
PS9, Line 6241: R
nit: indent
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@101
PS5, Line 101: ShowTabletI
> OK. I will use friend function.
One of the advantages of using frined class v.s friend function is the class name is much shorter than the function signature. In the latest patch set, the too long friend function signature in client.h seems a bit of code smell :)
cc @Alexey Serbin
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@109
PS9, Line 109: if (FLAGS_json) {
DataTable is support to output in JSON format(see DataTable::PrintTo), why deal with the JSON format especially?
http://gerrit.cloudera.org:8080/#/c/19501/9/src/kudu/tools/tool_action_tablet.cc@124
PS9, Line 124: cout << Substitute("Table id: $0, Table name: $1",
So if --json is enabled, table id and name will not be output?
How about add another CLI parameter --columns, and add table id and name to another output columns, like how dose 'kudu tserver list' do?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Mar 2023 16:10:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#20).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
id | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+-------+-------+-------+----
abc | test_table | xxxxx | host1 | 43689 | V
abd | test_table | xxxx1 | host2 | 43035 | L
dbe | test_table | xxxx2 | host3 | 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 135 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/20
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 20
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 18:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG@17
PS18, Line 17: exmple
example
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4152
PS18, Line 4152: // Stdout contains table name.
If we check the how line match a partten, it's not necessary to check the table name separatly.
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4159
PS18, Line 4159: ASSERT_STR_CONTAINS(stdout, cluster_->tablet_server(i)->bound_rpc_hostport().host());
How ablout to check the whole line by using regex by ASSERT_STR_MATCHES?
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4177
PS18, Line 4177: ASSERT_TRUE(item["Table Name"].GetString());
Same, check it match some parttens.
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@104
PS18, Line 104: kudu::
nit: can be omitted.
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@415
PS18, Line 415: on the table which the tablet is a part of
How about:
of the table which the tablet blongs to
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@416
PS18, Line 416: tablet
nit:
the tablet
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417
PS18, Line 417: .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc })
How about to support query multiple tablets info?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 18
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 10:59:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 4:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/3//COMMIT_MSG@13
PS3, Line 13: tablet i
> tablet id?
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h@1180
PS3, Line 1180: const std::string& id() const;
:
> I don't think these new methods are needed in the public client API if only
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h
File src/kudu/client/tablet-internal.h:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h@31
PS3, Line 31: Data
> +1
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto
File src/kudu/master/master.proto:
PS3:
> The newly added fields TabletLocationsPB::table_id and TabletLocationsPB::t
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448
PS3, Line 448: // DEPRECATED.
> Why do we need to assign values from 8?
The field interned_replicas is 7.
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448
PS3, Line 448: // DEPRECATED.
: // Used only if interned replic
> Whether is it necessary to move them to the end?
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@295
PS3, Line 295: K(CreateKudu
> 'FLAGS_format' has many values as below.
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@321
PS3, Line 321: cerr << "Replaced tablet " << tablet_id << " with tablet ";
> nit: remote an empty line
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: ilable.\n
> Alternatively, it could be just 'info'?
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 09:59:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#13).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 273 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/13
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 13
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 7:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/19501/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/5//COMMIT_MSG@9
PS5, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> Could give s sample output?
Done
http://gerrit.cloudera.org:8080/#/c/19501/6/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/6/src/kudu/client/client-internal.cc@298
PS6, Line 298: Status KuduClient::Data::GetTablet(KuduClient* client,
> warning: method 'GetTablet' can be made const [readability-make-member-func
Done
http://gerrit.cloudera.org:8080/#/c/19501/6/src/kudu/client/client-internal.cc@373
PS6, Line 373: Status KuduClient::Data::GetTabletServer(KuduClient* client,
> warning: method 'GetTabletServer' can be made const [readability-make-membe
Done
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto@460
PS5, Line 460: es id = 1;
> I guess this field rather belongs to GetTabletLocationsRequestPB?
You are right. I make a mismake.
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/master/master.proto@461
PS5, Line 461: optional string name = 2;
: }
> It would be great to create a dedicated message for this and add it just as
Done
http://gerrit.cloudera.org:8080/#/c/19501/6/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/6/src/kudu/tools/kudu-tool-test.cc@3967
PS6, Line 3967: ASSERT_STR_CONTAINS(stdout, workload_table->id());
> warning: 'opts' used after it was moved [bugprone-use-after-move]
Done
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: { kTablet
> +1
Done
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@101
PS5, Line 101: ShowTabletI
> This is C++, not Java, so I don't understand why to introduce otherwise use
OK. I will use friend function.
That is funny. Shower is an equipment of bathing. So learn English is not only about grammar but also culture.
Thank you for your comments.
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@126
PS5, Line 126: DataTable cmatrix({ "UUID", "Host
> Why would you need this? std::cout is std::ostream as well, so it fits whe
Done
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@127
PS5, Line 127: r (
> Would it be enough using 'cout' here?
Done
http://gerrit.cloudera.org:8080/#/c/19501/5/src/kudu/tools/tool_action_tablet.cc@136
PS5, Line 136: na
> nit: wrong indent?
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 13:23:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.h@103
PS15, Line 103: internal::RemoteTabletServer** ts) const;
This change is not matter with this patch, so you can fix it at another patch
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/client/client-internal.cc@293
PS15, Line 293: const
This change is not matter with this patch, so you can fix it at another patch
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/catalog_manager.h@800
PS15, Line 800: bool get_extra_info
what about move this parameters to GetTabletLocations, give it a default value false?
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/master/master.proto@459
PS15, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8;
move this line to the end? and writing some comments is better.
GetTabletLocationsResponsePB in GetTabletLocationsResponsePB is repeated, so this line seens move to GetTabletLocationsResponsePB is better to reduce duplicated infomation.
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc@a92
PS15, Line 92:
keep this empty line?
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc@76
PS15, Line 76: using kudu::master::TSInfoPB;
: using kudu::master::GetTabletLocationsRequestPB;
: using kudu::master::GetTabletLocationsResponsePB;
: using kudu::master::ReplaceTabletRequestPB;
: using kudu::master::ReplaceTabletResponsePB;
nit: order
using kudu::master::GetTabletLocationsRequestPB;
using kudu::master::GetTabletLocationsResponsePB;
using kudu::master::ReplaceTabletRequestPB;
using kudu::master::ReplaceTabletResponsePB;
using kudu::master::TSInfoPB;
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc@319
PS15, Line 319: deprecated_replicas
Don't use 'deprecated_replicas', it's an old deprecated historical field.
using interned_replicas instead if need.
interned_replicas or resp.tablet_locations has no TsInfo, interned_replicas has the TsInfo index.
You can use this to construct the response.
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc@415
PS15, Line 415: "info", &Info
What about 'describe', DescribeTablet?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 08:04:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/15/src/kudu/tools/tool_action_tablet.cc@319
PS15, Line 319: deprecated_replicas
> Don't use 'deprecated_replicas', it's an old deprecated historical field.
TsInfo is in GetTabletLocationsResponsePB
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 08:05:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name and all replicas on
different tablet servers according to the tablet id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
example:
Command: kudu tablet info $master_address $tablet_id
The result is:
ID | Table Name | Tablet Server UUID | Host | Port | Is Leader
-----+------------+--------------------+------+-------+----
abc | test_table | xxxxx | host1| 43689 | V
abd | test_table | xxxx1 | host2| 43035 | L
dbe | test_table | xxxx2 | host3| 35209 | V
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Reviewed-on: http://gerrit.cloudera.org:8080/19501
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/client/client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 135 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 25
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 19:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG@17
PS18, Line 17: exampl
> example
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4152
PS18, Line 4152: for (int i = 0; i < kNumTabletServers; i++) {
> If we check the how line match a partten, it's not necessary to check the t
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4159
PS18, Line 4159: }
> How ablout to check the whole line by using regex by ASSERT_STR_MATCHES?
It is hard to use ASSERT_STR_MATCHES, because the output order of every hosts is different. But I will check every line. Please review the next commit.
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/kudu-tool-test.cc@4177
PS18, Line 4177: // 1. Test the copy tool when the destination replica is healthy
> Same, check it match some parttens.
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@104
PS18, Line 104: client
> nit: can be omitted.
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@415
PS18, Line 415: of the table which the tablet blongs to "
> How about:
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@416
PS18, Line 416: the ta
> nit:
Done
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417
PS18, Line 417: .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc })
> How about to support query multiple tablets info?
Current solution will output empty if a tablet id is not existed. If this CLI supports query multiple tablet ids, it is difficult to make sure which one does not exist.
If you want to query multiple tablets at the same time, maybe you can use shell to implement it.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 19
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:49:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> Thank you. I think your solution is better. I will adopt your advice. Pleas
That means new fields are needed to be introduced, that is to say if you want to use such CLI feature, you must upgrade the Kudu cluster to the newer version. I don't think it's good idea. It's a common case that Kudu admins use a new version of Kudu CLI tool on old version of Kudu clusters, as long as the RPC is compactiable.
As I mentioned in https://gerrit.cloudera.org/c/19501/11/src/kudu/master/master.proto#459 is an alternative choice.
If the server doesn't support new RPC (with the new fields), backoff to compactiable RPC?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 04:06:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h@1180
PS2, Line 1180: const std::string& table_id() const;
: const std::string& table_name() const;
Expose functions to user client should be very carefully, we have to maintenace the user APIs for long time supporting.
If the function is only used in CLI tools, you can use KuduTablet::Data directly.
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/master/master.proto@449
PS2, Line 449: optional string table_name = 9;
If we want to use the feature we have to upgrade the servers, can we gather the table name from other existing methods?
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@292
PS2, Line 292: cout << Substitute("Table id: $0, Table name: $1",
: tablet->table_id(), tablet->table_name()) << endl;
: DataTable cmatrix({ "UUID", "Host", "Port", "Is Leader"});
The outputs are in two sections and in different format. If we only need the replica location output in JSON format and parsed by a 3rd party tool, how can we achieve that? Maybe control the output sections by another flag?
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/tools/tool_action_tablet.cc@300
PS2, Line 300: ostream out(std::cout.rdbuf());
: return cmatrix.PrintTo(out);
nit: return cmatrix.PrintTo(cout); ?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 15:25:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/19501/2/src/kudu/client/client.h@1180
PS2, Line 1180: const std::string& table_id() const;
: const std::string& table_name() const;
> KuduTablet::Data is private to CLI tools. Friendly class seems to be no sui
Reference to class TableAlter in src/kudu/tools/tool_action_table.cc, it's able to access private data of class KuduTableAlterer.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 15:28:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#4).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 287 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/4
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#9).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 294 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/9
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#10).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 283 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/10
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#11).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 279 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/11
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#3).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the table id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
9 files changed, 169 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/3
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/client.h@1180
PS3, Line 1180: const std::string& table_id() const;
: const std::string& table_name() const;
I don't think these new methods are needed in the public client API if only kudu CLI tools use these. Wouldn't it be enough to have corresponding fields in KuduTablet::Data?
For a reference, please take a look at how kudu::tools::TableLister uses internal::ReplicaController::Visibility to expose non-voter replicas in kudu CLI tools.
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto
File src/kudu/master/master.proto:
PS3:
The newly added fields TabletLocationsPB::table_id and TabletLocationsPB::table_name isn't needed anywhere but only in the newly added tool. If added to every response, these new fields will increase the size of GetTabletLocationsResponsePB and GetTableLocationsResponsePB. The latter might increase in size significantly, and the information in the newly added fields is duplicated, and it has no value at all for the callers of GetTableLocationsResponsePB. That would add unnecessary load to the kudu-master processes whose scalability is an issue for large clusters (200+ nodes) already.
I think the new fields should be populated conditionally, and only the newly added tools should request these to be filled in.
Consider adding a new boolean field similar to GetTabletLocationsRequestPB::intern_ts_infos_in_response, and set it only when necessary. Probably, it would be necessary to add a new method into KuduClient::Data() interface, and use it in the CLI tools and reuse in the implementation of KuduClient::GetTablet(). Basically, the implementation of KuduClient::GetTablet() should be moved into KuduClient::Data::GetTablet() and modified, and KuduClient::GetTablet() would simply call KuduClient::Data::GetTablet() with corresponding parameters.
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: show_info
> what about 'describe' ?
Alternatively, it could be just 'info'?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 25 Feb 2023 02:46:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h
File src/kudu/client/tablet-internal.h:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/client/tablet-internal.h@31
PS3, Line 31: Data
The variables' initialize order in construct function show be same as the order happens in class ?
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/master/master.proto@448
PS3, Line 448: optional bytes table_id = 8;
: optional string table_name = 9;
Whether is it necessary to move them to the end?
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/kudu-tool-test.cc@3996
PS3, Line 3996: ASSERT_GE
This assert seems useless?
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@295
PS3, Line 295: FLAGS_format
'FLAGS_format' has many values as below.
125 DEFINE_string(format, "pretty",
126 "Format to use for printing list output tables.\n"
127 "Possible values: pretty, space, tsv, csv, and json");
If we only focus on 'json', I think the gflag 'FLAGS_json' as below may be better.
'src/kudu/tools/tool_action_pbc.cc:70:DEFINE_bool(json, false, "Print protobufs in JSON format");'
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@321
PS3, Line 321:
nit: remote an empty line
http://gerrit.cloudera.org:8080/#/c/19501/3/src/kudu/tools/tool_action_tablet.cc@409
PS3, Line 409: show_info
what about 'describe' ?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 11:41:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#5).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging.
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/tablet-internal.cc
M src/kudu/client/tablet-internal.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_tablet.cc
13 files changed, 287 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/5
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
> Patch Set 15:
>
> (1 comment)
How about other people's opinion?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 06:46:15 +0000
Gerrit-HasComments: No
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459
PS11, Line 459: message TableInfoPB {
> Of course it's convenient to obtain table info by sending GetTabletLocation
typo: If reusing ListTablesResponsePB, the new CLI tool is compatiable with the old version servers too.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 31 Mar 2023 15:41:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 15:
(1 comment)
> Patch Set 15:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
: replicas on different tablet servers according to the tablet
: id.
> That means new fields are needed to be introduced, that is to say if you wa
I think both solutions can unified as one.
Using Yingchun's idea can solve this patch without upgrading kudu-masters, but it's not an optimal solution. Because it need 2 rpcs: one GetTabletLocations, the other ListTables(with list_tablets) and need keep the response and search ListTables's response the search tablet_id and table name and fill up CLI' information.
Using this idea can be an optimal solution for this but need upgrading masters. Without upgrading masters, it works well too, and can't cause serious problems, but table id and table name is absent at CLI side, that's weakness when a new CLI tool requests to old masters.
Both advantages is what we need. kudu would keep evolutions, a newer CLI on old master is not long-term status, same versions of kudu CLI and master is a long-term status, So I think, based this solution to be compatible with old masters, that is if table id and table name is absent, downgrade to ListTables to search and fill up the information.
What do you think? And others?
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 15
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 09:46:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, KeDeng,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19501
to look at the new patch set (#16).
Change subject: [Tool] Show the information of a tablet
......................................................................
[Tool] Show the information of a tablet
This tool is used to show the table name, table id and all
replicas on different tablet servers according to the tablet
id.
Sometimes, the log prints the tablet id when a query failed or
the system got something wrong. But it is difficult to find
useful information according to the tablet id.
This tool will be helpful for debuging. The following is an
exmple:
Command: kudu tablet info $master_address $tablet_id
The result is:
Table name: test_table
Tablet Server UUID | Host | Port | Is Leader
----------------------------------+-----------------+-------+-----------
4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true
65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false
6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false
Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client.h
M src/kudu/master/catalog_manager.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_tablet.cc
5 files changed, 139 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/19501/16
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 16
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19501/18//COMMIT_MSG@22
PS18, Line 22: Table name: test_table
Is it out of date? I see the table name is a column of the table below in the latest implemention.
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 18
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 12 Jun 2023 03:56:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Tool] Show the information of a tablet
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:
http://gerrit.cloudera.org:8080/#/c/19501/18/src/kudu/tools/tool_action_tablet.cc@417
PS18, Line 417: unique_ptr<Action> info =
> Maybe adding a column for 'tablet id' in the table can resolve it.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 20
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 14:27:07 +0000
Gerrit-HasComments: Yes