You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "jongyoul (via GitHub)" <gi...@apache.org> on 2026/08/12 03:19:50 UTC

[PR] [ZEPPELIN-6528] Handle forbidden interpreter responses in classic UI [zeppelin]

jongyoul opened a new pull request, #5416:
URL: https://github.com/apache/zeppelin/pull/5416

   ### What is this PR for?
   
   Apache Shiro 2.0.6 returns HTTP 403 for an authenticated user who lacks a required role. Shiro 1.13.0 returned HTTP 401 for the same authorization denial.
   
   The classic interpreter page only handled HTTP 401, so a 403 response did not show the permission error toast or redirect the user. This also caused `AuthenticationIT.testAnyOfRolesUser` to fail with `Expected ngToast not found`.
   
   This PR handles both 401 and 403 responses and adds controller tests covering both statuses.
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### Todos
   
   * [x] Handle HTTP 403 authorization denials in the classic interpreter page
   * [x] Preserve the existing HTTP 401 behavior
   * [x] Add regression tests for both response statuses
   
   ### What is the Jira issue?
   
   * https://issues.apache.org/jira/browse/ZEPPELIN-6528
   
   ### How should this be tested?
   
   ```bash
   cd zeppelin-web
   npm run karma-test -- --single-run
   ```
   
   Local validation:
   
   * ESLint passed for the changed controller and test.
   * `git diff --check` passed.
   * Karma compiled the application and test bundle successfully, but the browser run could not start locally because Firefox is not installed in the worktree environment.
   
   ### Screenshots
   
   N/A
   
   ### Questions
   
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this need documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6528] Handle forbidden interpreter responses in classic UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #5416:
URL: https://github.com/apache/zeppelin/pull/5416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6528] Handle forbidden interpreter responses in classic UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5416:
URL: https://github.com/apache/zeppelin/pull/5416#issuecomment-5263510181

   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org