You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/21 22:09:51 UTC

[GitHub] Licht-T commented on a change in pull request #1080: ENH: Apply `make format` into C++ client

Licht-T commented on a change in pull request #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#discussion_r162827261
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/CompressionType.h
 ##########
 @@ -20,11 +20,7 @@
 #define PULSAR_COMPRESSIONTYPE_H_
 #pragma GCC visibility push(default)
 namespace pulsar {
-enum CompressionType {
-    CompressionNone = 0,
-    CompressionLZ4 = 1,
-    CompressionZLib = 2
-};
+enum CompressionType { CompressionNone = 0, CompressionLZ4 = 1, CompressionZLib = 2 };
 
 Review comment:
   @merlimat @maskit We can keep enums in separate lines by this, but the new line inserted between the definition and the brace.
   https://github.com/apache/incubator-pulsar/pull/1080/files#diff-f5034129a6e7700b144e19b41534c1afR25
   https://github.com/apache/incubator-pulsar/pull/1080/files#diff-2327e49613e902fe01fad24b083bc888R23

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services