You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/26 12:38:09 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #13513: Compaction threshold policies support cross multiple clusters
mattisonchao opened a new pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513
Master Issue: #13444
### Motivation
Compaction threshold policies support cross multiple clusters.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1003010907
@codelipenghui
The current conflict is resolved and we need to wait for CI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1002966544
@mattisonchao Could you please help resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1001196057
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1001173309
@315157973 @codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao removed a comment on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1002342867
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao removed a comment on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1003009913
@codelipenghui
Yes, but I have another PR for this feature. If it is merged into master, this pr will conflict again.
So, I think I need to resolve the conflict gradually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1002342867
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on a change in pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#discussion_r775448309
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4213,27 +4213,30 @@ protected void internalGetLastMessageId(AsyncResponse asyncResponse, boolean aut
}));
}
- protected CompletableFuture<Void> internalSetCompactionThreshold(Long compactionThreshold) {
+ protected CompletableFuture<Void> internalSetCompactionThreshold(Long compactionThreshold , boolean isGlobal) {
Review comment:
```suggestion
protected CompletableFuture<Void> internalSetCompactionThreshold(Long compactionThreshold, boolean isGlobal) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 merged pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
315157973 merged pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1002358658
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1003009913
@codelipenghui
Yes, but I have another PR for this feature. If it is merged into master, this pr will conflict again.
So, I think I need to resolve the conflict gradually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13513: Compaction threshold policies support cross multiple clusters
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13513:
URL: https://github.com/apache/pulsar/pull/13513#issuecomment-1003010232
> @mattisonchao Could you please help resolve the conflicts?
Yes, i will do it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org