You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/21 02:43:20 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #602: Fixes an issue that could not search on zone select
utchoang opened a new pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602
@rhtyd cc @svenvogel I found 1 issue: We can't search on zone select input in creating/upload templates/isos. I've fixed it. Thanks.
* Before:
*After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678259822
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678260245
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678902009
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678299705
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/602 (JID-3322)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r475294827
##########
File path: src/views/image/RegisterOrUploadIso.vue
##########
@@ -90,14 +90,7 @@
:loading="zoneLoading"
:placeholder="apiParams.zoneid.description">
<a-select-option :value="opt.id" v-for="opt in zones" :key="opt.id">
- <div v-if="currentForm === 'Upload'">
- <div v-if="opt.name !== $t('label.all.zone')">
- {{ opt.name || opt.description }}
- </div>
- </div>
- <div v-else>
- {{ opt.name || opt.description }}
- </div>
+ {{ opt.name || opt.description }}
Review comment:
@rhtyd All zone not showing on upload templates/isos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678904613
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/602 (JID-3357)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r474670363
##########
File path: src/views/image/RegisterOrUploadIso.vue
##########
@@ -90,14 +90,7 @@
:loading="zoneLoading"
:placeholder="apiParams.zoneid.description">
<a-select-option :value="opt.id" v-for="opt in zones" :key="opt.id">
- <div v-if="currentForm === 'Upload'">
- <div v-if="opt.name !== $t('label.all.zone')">
- {{ opt.name || opt.description }}
- </div>
- </div>
- <div v-else>
- {{ opt.name || opt.description }}
- </div>
+ {{ opt.name || opt.description }}
Review comment:
@rhtyd It's not showing for upload
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678170422
@davidjumani I fixed this error. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678263629
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/602 (JID-3317)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678309585
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/602 (JID-3323)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r474669372
##########
File path: src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -94,6 +94,10 @@
}]"
:loading="zones.loading"
mode="multiple"
+ optionFilterProp="children"
+ :filterOption="(input, option) => {
+ return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }"
Review comment:
@utchoang Could you add the same to zone selection in line 130 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678136348
@utchoang Looks good for registering via url for templates. Could you also do the same when it's to upload a template too ?
Also an error while trying to register via url for iso :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r474663565
##########
File path: src/views/image/RegisterOrUploadIso.vue
##########
@@ -90,14 +90,7 @@
:loading="zoneLoading"
:placeholder="apiParams.zoneid.description">
<a-select-option :value="opt.id" v-for="opt in zones" :key="opt.id">
- <div v-if="currentForm === 'Upload'">
- <div v-if="opt.name !== $t('label.all.zone')">
- {{ opt.name || opt.description }}
- </div>
- </div>
- <div v-else>
- {{ opt.name || opt.description }}
- </div>
+ {{ opt.name || opt.description }}
Review comment:
@utchoang @davidjumani have you tested the case that when uploading, all zones are not shown; but when registering by URL then all zones option is shown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678130338
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/602 (JID-3312)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678125770
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678136348
@utchoang Looks good for registering via url for templates. Could you also do the same when it's to upload a template too ?
Also an error while trying to upload an iso :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678126291
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678901894
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#discussion_r474669372
##########
File path: src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -94,6 +94,10 @@
}]"
:loading="zones.loading"
mode="multiple"
+ optionFilterProp="children"
+ :filterOption="(input, option) => {
+ return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }"
Review comment:
@utchoang Could you add the same to zone selection on line 130 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678136348
@utchoang Looks good. Could you also do the same when it's to upload a template too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #602: Fixes an issue that could not search on zone select
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602#issuecomment-678964492
@rhtyd Good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org